feat(cjux-278): maintenance root roles #8875
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
Tymek
changed the title
Tymek
requested review from
sjaanus,
kwasniew,
FredrikOseberg and
thomasheartman
| @@ -6,10 +6,11 @@ import { Box, styled } from '@mui/material'; | |||
| import useUiConfig from 'hooks/api/getters/useUiConfig/useUiConfig'; | |||
| import { MaintenanceTooltip } from './MaintenanceTooltip'; | |||
| import { MaintenanceToggle } from './MaintenanceToggle'; | |||
| import { UPDATE_MAINTENANCE_MODE } from '@server/types/permissions'; | |||
There was a problem hiding this comment.
I didn't know we could import stuff from the server? Should it go in AccessProvider/permissions to be consistent with how we're doing it today? I think only defining it in one place is cool, though, but why is it not something we're already doing?
There was a problem hiding this comment.
Thanks for noticing this. It needs refactoring. I'll post another PR, because it turns out there are inconsistencies all over this.
| export const MAINTENANCE_MODE_PERMISSIONS = [ | ||
| ADMIN, | ||
| READ_ROLE, | ||
| READ_CLIENT_API_TOKEN, | ||
| READ_FRONTEND_API_TOKEN, | ||
| UPDATE_MAINTENANCE_MODE, |
There was a problem hiding this comment.
How does this work? Do you need one of them or all of them? Seems a little strange to gain access to the full admin panel if you have read client API token only? Maybe I'm misunderstanding how this works?
There was a problem hiding this comment.
We don't have a way to selectively show some tabs (yet). It's a way to at least show all options, and PermissionGuard wrapper will do block further UI
Custom root roles for changing maintenance mode state and banners.
Internal ticket: CJUX-278