feat: selector dropdown for milestone new strategy #8841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
daveleek
commented
Nov 22, 2024
| }} | ||
| > | ||
| <MilestoneStrategyMenuCards | ||
| milestoneId={milestone.id ?? index.toString()} |
There was a problem hiding this comment.
Temporary, also going to use uuidv4() to generate an id for milestones
nunogois
reviewed
Nov 22, 2024
|
|
||
| interface IMilestoneStrategyMenuCardProps { | ||
| strategy: IStrategy; | ||
| strategyClicked: (strategy: IReleasePlanMilestoneStrategy) => void; |
There was a problem hiding this comment.
Suggested change
| strategyClicked: (strategy: IReleasePlanMilestoneStrategy) => void; | |
| onClick: (strategy: IReleasePlanMilestoneStrategy) => void; |
nunogois
reviewed
Nov 22, 2024
| @@ -9,7 +12,10 @@ interface IMilestoneListProps { | |||
| setMilestones: React.Dispatch< | |||
| React.SetStateAction<IReleasePlanMilestonePayload[]> | |||
| >; | |||
| setAddStrategyOpen: (open: boolean) => void; | |||
| openAddStrategyForm: ( | |||
| index: number, | |||
There was a problem hiding this comment.
I think this is going to be increasingly more difficult to maintain. Maybe we should call it something else. I think this is the milestoneIndex, right?
nunogois
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a dropdown for selecting which strategy type to add to the milestone