fix: isOss check + minor UI things #8828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because these are the same sentence, they shouldn't be separate paragraphs. So instead, we wrap them in spans and surround them in a p. Display contents makes the p "invisible", so its children act as if they're children of the container above it instead.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
sjaanus
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the isOss check for the licensed users component. It also addresses two things in the UI:
And when you focus it with a keyboard it still looks like a button.
We can get around that by using a regular button and just styling it a bit, but making the text align will take some extra jimmying around (not done in this pr, but got stashed changes for it)
But this is what it'd look like now with centered text:
ptag, because they belong together. They're not two logical paragraphs. So instead, we wrap them in spans and surround them in ap.
Display: contentsmakes the p "invisible", so its children act as ifthey're children of the container above it instead.