Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: display the build number as extra data #8022

Merged
merged 5 commits into from
Aug 30, 2024

Conversation

gastonfournier
Copy link
Contributor

About the changes

Show the build number between parenthesis separated from the version.

When there's no build number:
image

When there is:
image

Copy link

vercel bot commented Aug 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2024 1:55pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Visit Preview Aug 30, 2024 1:55pm

Copy link
Contributor

github-actions bot commented Aug 30, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

Copy link
Member

@nunogois nunogois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot we also had ({environment}) there so it doesn't look as nice as I hoped. Do we still need that?

Maybe UX can help figure out the ideal way of displaying this information.

@gastonfournier
Copy link
Contributor Author

I forgot we also had ({environment}) there so it doesn't look as nice as I hoped. Do we still need that?

Maybe UX can help figure out the ideal way of displaying this information.

I also thought we might change that later, but I rather do this now and another improvement later. Despite that let me send this over to UX

@gastonfournier
Copy link
Contributor Author

Failing e2e cypress test don't seem related but they fail consistently. I'll merge without them

@gastonfournier gastonfournier merged commit bb5aa64 into main Aug 30, 2024
9 of 11 checks passed
@gastonfournier gastonfournier deleted the improve-version-display branch August 30, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants