Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: add limits to feature flags #7536

Merged
merged 8 commits into from
Jul 4, 2024
Merged

Chore: add limits to feature flags #7536

merged 8 commits into from
Jul 4, 2024

Conversation

thomasheartman
Copy link
Contributor

@thomasheartman thomasheartman commented Jul 3, 2024 •
edited
Loading

This PR adds a feature flag limit to Unleash. It's set up to be overridden in Enterprise, where we turn the limit up.

I've also fixed a couple bugs in the fake feature flag store.

@vercel Vercel
Copy link

vercel bot commented Jul 3, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 4, 2024 8:25am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Visit Preview Jul 4, 2024 8:25am

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 3, 2024 •
edited
Loading

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

@thomasheartman thomasheartman requested a review from kwasniew July 4, 2024 07:39
kwasniew
kwasniew reviewed Jul 4, 2024
View reviewed changes
src/lib/create-config.ts Outdated Show resolved Hide resolved
kwasniew
kwasniew approved these changes Jul 4, 2024
View reviewed changes
Copy link
Contributor

@kwasniew kwasniew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice that you improved the fake store along the way

@thomasheartman thomasheartman requested review from kwasniew and Tymek July 4, 2024 07:53
@thomasheartman thomasheartman enabled auto-merge (squash) July 4, 2024 07:57
@thomasheartman thomasheartman disabled auto-merge July 4, 2024 08:00
@thomasheartman thomasheartman merged commit 59d6014 into main Jul 4, 2024
12 checks passed
@thomasheartman thomasheartman deleted the feat/1-2506-api-soft-limit-for-flags branch July 4, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwasniew kwasniew Awaiting requested review from kwasniew

@Tymek Tymek Awaiting requested review from Tymek

Assignees

@thomasheartman thomasheartman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thomasheartman @kwasniew