Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "fix: yarn v4 requires prepack instead of prepare script when building…" #7373

Merged
merged 2 commits into from
Jun 12, 2024
Merged

Revert "fix: yarn v4 requires prepack instead of prepare script when building…" #7373

merged 2 commits into from
Jun 12, 2024

Conversation

gastonfournier
Copy link
Contributor

Reverts #7371

@vercel Vercel
Copy link

vercel bot commented Jun 12, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 12, 2024 11:25am
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 12, 2024 11:25am

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 12, 2024 •
edited
Loading

Dependency Review

The following issues were found:

  • ✅ 0 vulnerable package(s)
  • ✅ 0 package(s) with incompatible licenses
  • ✅ 0 package(s) with invalid SPDX license definitions
  • ⚠️ 7 package(s) with unknown licenses.
  • ⚠️ 23 packages with OpenSSF Scorecard issues.

View full job summary

@gastonfournier
Revert "task: Yarn v4 (#7345)" (#7374)
0b06e74 
This reverts commit a971c77.

<!-- Thanks for creating a PR! To make it easier for reviewers and
everyone else to understand what your changes relate to, please add some
relevant content to the headings below. Feel free to ignore or delete
sections that you don't think are relevant. Thank you! ❤️ -->

## About the changes
<!-- Describe the changes introduced. What are they and why are they
being introduced? Feel free to also add screenshots or steps to view the
changes if they're visual. -->

<!-- Does it close an issue? Multiple? -->
Closes #

<!-- (For internal contributors): Does it relate to an issue on public
roadmap? -->
<!--
Relates to [roadmap](https://github.com/orgs/Unleash/projects/10) item:
#
-->

### Important files
<!-- PRs can contain a lot of changes, but not all changes are equally
important. Where should a reviewer start looking to get an overview of
the changes? Are any files particularly important? -->


## Discussion points
<!-- Anything about the PR you'd like to discuss before it gets merged?
Got any questions or doubts? -->
chriswk
chriswk approved these changes Jun 12, 2024
View reviewed changes
Copy link
Member

@chriswk chriswk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sad approve

@gastonfournier gastonfournier merged commit a0fce0e into main Jun 12, 2024
15 checks passed
@gastonfournier gastonfournier deleted the revert-7371-task/addPrepackScript branch June 12, 2024 11:25
chriswk added a commit that referenced this pull request Jun 12, 2024
@chriswk
Reapply "fix: yarn v4 requires prepack instead of prepare script when…
5d02e3e 
… building…" (#7373)

This reverts commit a0fce0e.
chriswk added a commit that referenced this pull request Jun 24, 2024
@chriswk
Reapply "fix: yarn v4 requires prepack instead of prepare script when…
b40fe56 
… building…" (#7373)

This reverts commit a0fce0e.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chriswk chriswk chriswk approved these changes

@alvinometric alvinometric Awaiting requested review from alvinometric

@nnennandukwe nnennandukwe Awaiting requested review from nnennandukwe

Assignees

@gastonfournier gastonfournier

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gastonfournier @chriswk