-
-
Notifications
You must be signed in to change notification settings - Fork 727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Merged 11 principles articles into a single document #7266
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
'/topics/feature-flags/prioritize-ux', | ||
'/topics/feature-flags/enable-traceability', | ||
], | ||
to: '/topics/feature-flags/feature-flag-best-practices', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep in mind that these redirects are purely client side, which generally is bad for SEO. We have established server side redirects here: https://github.com/Unleash/unleash/blob/main/website/vercel.json.
(On that note we are getting quite a few redirects in now, we need to review them over time as they add complexity and there might be limits at Vercel that we are not aware of, its not uncommon to have an upper limits on these rules to keep performance under control.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll bring this up with @riboflavin so we can run an audit on our existing redirects to see if they get much traffic. Then we can start to trim down the list
Can you elaborate a bit on the purpose of this change? Is it purely UX optimization, or are we trying to achieve some specific benefits here? |
It's both for SEO and UX 😄 |
Just like #7266, this consolidates the "Best Practices for Migrating from a Homegrown Feature Management Solution" article into a single document, that you can navigate using the TOC on the right side, rather than the sidebar on the left hand side. We also update the redirects to that the old links still work. This also correctly sets @ardeche07 as an Unleash team member 😅
This consolidates the "11 Principles for building and scaling feature flag systems" article into a single document, that you can navigate using the TOC on the right side, rather than the sidebar on the left hand side.
This also updates the redirects to that the old links still work.