Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Merged 11 principles articles into a single document #7266

Merged
merged 2 commits into from
Jun 7, 2024

Conversation

alvinometric
Copy link
Contributor

This consolidates the "11 Principles for building and scaling feature flag systems" article into a single document, that you can navigate using the TOC on the right side, rather than the sidebar on the left hand side.

This also updates the redirects to that the old links still work.

Copy link

vercel bot commented Jun 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 4, 2024 10:16am
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 4, 2024 10:16am

Copy link
Contributor

github-actions bot commented Jun 4, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

'/topics/feature-flags/prioritize-ux',
'/topics/feature-flags/enable-traceability',
],
to: '/topics/feature-flags/feature-flag-best-practices',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep in mind that these redirects are purely client side, which generally is bad for SEO. We have established server side redirects here: https://github.com/Unleash/unleash/blob/main/website/vercel.json.

(On that note we are getting quite a few redirects in now, we need to review them over time as they add complexity and there might be limits at Vercel that we are not aware of, its not uncommon to have an upper limits on these rules to keep performance under control.)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll bring this up with @riboflavin so we can run an audit on our existing redirects to see if they get much traffic. Then we can start to trim down the list

@ivarconr
Copy link
Member

ivarconr commented Jun 4, 2024

This consolidates the "11 Principles for building and scaling feature flag systems" article into a single document, that you can navigate using the TOC on the right side, rather than the sidebar on the left hand side.

Can you elaborate a bit on the purpose of this change? Is it purely UX optimization, or are we trying to achieve some specific benefits here?

@alvinometric
Copy link
Contributor Author

It's both for SEO and UX 😄

@alvinometric alvinometric merged commit f8abfee into main Jun 7, 2024
11 of 12 checks passed
@alvinometric alvinometric deleted the alvin/merge-principles-articles branch June 7, 2024 12:30
alvinometric added a commit that referenced this pull request Jun 10, 2024
Just like #7266, this consolidates the "Best Practices for Migrating
from a Homegrown Feature Management Solution" article into a single
document, that you can navigate using the TOC on the right side, rather
than the sidebar on the left hand side.

We also update the redirects to that the old links still work.

This also correctly sets @ardeche07 as an Unleash team member 😅
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants