Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: increase possible number range for yes/no metrics #6995

Merged
merged 1 commit into from
May 7, 2024

Conversation

kwasniew
Copy link
Contributor

@kwasniew kwasniew commented May 7, 2024

About the changes

Daily metrics for feature yes/no are approaching integer limits so changing it to bigint.

This table is queries in two places:

  • for the metrics display where the reducer is already casting string (knex type for pg bigint) to number
       yes: Number(yes),
       no: Number(no),
  • for the insights aggregation where total_yes and total_no are already bigint so no issue here
  .sum({ total_yes: 'cmed.yes' })
  .sum({ total_no: 'cmed.no' })

Important files

Discussion points

Copy link

vercel bot commented May 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Visit Preview May 7, 2024 8:52am
unleash-monorepo-frontend ⬜️ Ignored (Inspect) Visit Preview May 7, 2024 8:52am

@kwasniew kwasniew requested a review from sjaanus May 7, 2024 08:54
@kwasniew kwasniew merged commit d1803b2 into main May 7, 2024
10 checks passed
@kwasniew kwasniew deleted the client_metrics_env_daily_bigint branch May 7, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants