Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Insights placement in drawer nav #6846

Merged
merged 2 commits into from
Apr 12, 2024

Conversation

andreas-unleash
Copy link
Contributor

Moves the Insights nav menu item down to match desktop ordering

Closes # 1-2290
Screenshot 2024-04-12 at 13 12 25

Copy link

vercel bot commented Apr 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 12, 2024 11:16am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Visit Preview Apr 12, 2024 11:16am

@@ -173,6 +162,17 @@ export const routes: IRoute[] = [
menu: { mobile: true },
},

// Insights - previously "Executive dashboard"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can remove this

Copy link
Contributor

@sjaanus sjaanus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with comment

Signed-off-by: andreas-unleash <[email protected]>
@andreas-unleash andreas-unleash merged commit 34e917f into main Apr 12, 2024
13 checks passed
@andreas-unleash andreas-unleash deleted the fix/insights_nav_in_mobile_menu branch April 12, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants