Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change time based feedback to button #6837

Merged
merged 2 commits into from
Apr 15, 2024
Merged

feat: change time based feedback to button #6837

merged 2 commits into from
Apr 15, 2024

Conversation

sjaanus
Copy link
Contributor

@sjaanus sjaanus commented Apr 11, 2024

image

Copy link

vercel bot commented Apr 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 15, 2024 8:44am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Visit Preview Apr 15, 2024 8:44am

Copy link

@codescene-delta-analysis codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Health Quality Gates: OK

  • Declining Code Health: 1 findings(s) 🚩

View detailed results in CodeScene

Copy link
Contributor

@FredrikOseberg FredrikOseberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Did you verify how this looks on a smaller screen? We should just hide it here I think.

Copy link

@codescene-delta-analysis codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Health Quality Gates: OK

  • Declining Code Health: 1 findings(s) 🚩

View detailed results in CodeScene

Comment on lines +62 to +65
const projectOverviewRefactorFeedback = useUiFlag(
'projectOverviewRefactorFeedback',
);
const { openFeedback } = useFeedback('newProjectOverview', 'automatic');

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Getting worse: Large Method
ProjectFeatureTogglesHeader:VFC<IProjectFeatureTogglesHeaderProps> increases from 136 to 165 lines of code, threshold = 120

Suppress

@sjaanus sjaanus merged commit 9aee1a7 into main Apr 15, 2024
13 checks passed
@sjaanus sjaanus deleted the project-feedback branch April 15, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants