chore: remove archived column from features table #6431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Code Health Quality Gates: OK
- Declining Code Health: 0 findings(s) 🚩
- Improving Code Health: 1 findings(s) ✅
- Affected Hotspots: 1 files(s) 🔥
Recommended Review Level: Lightweight sanity check
View detailed results in CodeScene
✅ Improving Code Health:
- Lines of Code in a Single File project-service.e2e.test.ts 🔥
| @@ -2070,19 +2070,15 @@ test('should get correct amount of features archived in current and past window' | |||
| await Promise.all([ | |||
| updateFeature(toggles[0].name, { | |||
| archived_at: new Date(), | |||
| archived: true, | |||
There was a problem hiding this comment.
✅ Getting better: Lines of Code in a Single File
The lines of code decreases from 2087 to 2083, improve code health by reducing it to 1000
Why does this problem occur?
The number of Lines of Code in a single file. More Lines of Code lowers the code health. Read more.
There was a problem hiding this comment.
✅ Code Health Quality Gates: OK
- Declining Code Health: 0 findings(s) 🚩
- Improving Code Health: 1 findings(s) ✅
- Affected Hotspots: 1 files(s) 🔥
Recommended Review Level: Lightweight sanity check
View detailed results in CodeScene
✅ Improving Code Health:
- Lines of Code in a Single File project-service.e2e.test.ts 🔥
kwasniew
reviewed
Mar 5, 2024
kwasniew
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This column has not been used for 1.5 years and was replace by archived_at column and people still get confused of why this is not working as name suggests. Removing this column to remove technical debt.