chore: action events UI #6358
chore: action events UI #6358
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Code Health Quality Gates: FAILED
- Declining Code Health: 3 findings(s) 🚩
- Improving Code Health: 0 findings(s) ✅
- Affected Hotspots: 0 files(s) 🔥
Recommended Review Level: Detailed -- Inspect the code that degrades in code health.
View detailed results in CodeScene
🚩 Declining Code Health (highest to lowest):
- Large Method ProjectActionsTable.tsx: ProjectActionsTable
- Large Method ProjectActionsModal.tsx: ProjectActionsModal
- Complex Conditional useActionEvents.ts: getKey:SWRInfiniteKeyLoader
| @@ -49,6 +50,7 @@ export const ProjectActionsTable = ({ | |||
| const { incomingWebhooks } = useIncomingWebhooks(); | |||
| const { serviceAccounts } = useServiceAccounts(); | |||
|
|
|||
| const [eventsModalOpen, setEventsModalOpen] = useState(false); | |||
There was a problem hiding this comment.
❌ Getting worse: Large Method
ProjectActionsTable increases from 220 to 238 lines of code, threshold = 120
Why does this problem occur?
Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function. Read more.
To ignore this warning click here.
| if ( | ||
| !actionSetId || | ||
| !projectId || | ||
| !isEnterprise || |
There was a problem hiding this comment.
❌ New issue: Complex Conditional
getKey:SWRInfiniteKeyLoader has 1 complex conditionals with 3 branches, threshold = 2
Why does this problem occur?
A complex conditional is an expression inside a branch (e.g. if, for, while) which consists of multiple, logical operators such as AND/OR. The more logical operators in an expression, the more severe the code smell. Read more.
To ignore this warning click here.
There was a problem hiding this comment.
❌ Code Health Quality Gates: FAILED
- Declining Code Health: 4 findings(s) 🚩
- Improving Code Health: 0 findings(s) ✅
- Affected Hotspots: 0 files(s) 🔥
Recommended Review Level: Detailed -- Inspect the code that degrades in code health.
View detailed results in CodeScene
🚩 Declining Code Health (highest to lowest):
- Large Method ProjectActionsTable.tsx: ProjectActionsTable
- Large Method ProjectActionsModal.tsx: ProjectActionsModal
- Large Method IncomingWebhooksModal.tsx: IncomingWebhooksModal
- Complex Conditional useActionEvents.ts: getKey:SWRInfiniteKeyLoader
| } | ||
|
|
||
| export const ProjectActionsModal = ({ | ||
| action, | ||
| open, | ||
| setOpen, | ||
| onOpenEvents, |
There was a problem hiding this comment.
❌ Getting worse: Large Method
ProjectActionsModal increases from 140 to 147 lines of code, threshold = 120
Why does this problem occur?
Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function. Read more.
To ignore this warning click here.
| <ConditionallyRender | ||
| condition={editing} | ||
| show={<Link onClick={onOpenEvents}>View events</Link>} | ||
| /> |
There was a problem hiding this comment.
❌ New issue: Large Method
IncomingWebhooksModal has 138 lines, threshold = 120
Why does this problem occur?
Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function. Read more.
To ignore this warning click here.
| flex: 1, | ||
| padding: theme.spacing(2), | ||
| fontSize: theme.fontSizes.smallBody, | ||
| justifyContent: align, | ||
| ...(maxWidth && { maxWidth }), | ||
| textAlign: align, | ||
| alignItems: 'center', |
There was a problem hiding this comment.
Will this and the display change above affect other UI components? I'm just worried this might cause unnoticed changes a few days prior a release
There was a problem hiding this comment.
SidePanelList is a new component introduced in #6317 so I wouldn't worry about it.
The only other place where we're using it, Incoming webhook events, also looks correct with this change.
https://linear.app/unleash/issue/2-1936/action-events-ui
Implements the UI for action events.