chore: remove mermaid in favor of react archer #6320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
kwasniew
reviewed
Feb 22, 2024
| return <Alert severity='warning'>No data available.</Alert>; | ||
| } | ||
|
|
||
| const mockApps = new Array(30).fill(1).map((_, i) => ({ |
There was a problem hiding this comment.
is the mock apps intended?
There was a problem hiding this comment.
Oops, you're right. I thought I had reverted this but it slipped by. Nice catch! Cleaned up in b2221f7
kwasniew
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://linear.app/unleash/issue/2-1968/use-react-archer-instead-of-mermaid-in-the-network-overview
This PR removes mermaid in favor of react-archer, which meant adapting
NetworkOverviewto usereact-archerinstead, since that was the only remaining feature usingmermaid.Opted not to use RPS labels in the lines since it was very noisy visually. Took the liberty to make some visual changes, but we can align afterwards with @nicolaesocaciu if needed.
Example with 1 app
Example with 3 apps
Example with 30 apps
Example in light theme