-
-
Notifications
You must be signed in to change notification settings - Fork 730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: incoming webhook events UI #6317
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
12d196b
chore: incoming webhook events UI
nunogois ae141a4
ongoing implementation of incoming webhook events UI
nunogois 34afdef
chore: ongoing development of SidePanelList
nunogois 3337976
chore: finish first implementation of SidePanelList
nunogois e09f279
chore: implement load more
nunogois f35add8
fix: remove empty title prop
nunogois File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
122 changes: 122 additions & 0 deletions
122
frontend/src/component/common/SidePanelList/SidePanelList.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,122 @@ | ||
| import { styled } from '@mui/material'; | ||
| import { ReactNode, useState } from 'react'; | ||
| import { SidePanelListHeader } from './SidePanelListHeader'; | ||
| import { SidePanelListItem } from './SidePanelListItem'; | ||
|
|
||
| const StyledSidePanelListWrapper = styled('div')({ | ||
| display: 'flex', | ||
| flexDirection: 'column', | ||
| width: '100%', | ||
| }); | ||
|
|
||
| const StyledSidePanelListBody = styled('div')({ | ||
| display: 'flex', | ||
| flexDirection: 'row', | ||
| }); | ||
|
|
||
| const StyledSidePanelHalf = styled('div')({ | ||
| display: 'flex', | ||
| flexDirection: 'column', | ||
| flex: 1, | ||
| }); | ||
|
|
||
| const StyledSidePanelHalfLeft = styled(StyledSidePanelHalf, { | ||
| shouldForwardProp: (prop) => prop !== 'height', | ||
| })<{ height?: number }>(({ theme, height }) => ({ | ||
| border: `1px solid ${theme.palette.divider}`, | ||
| borderTop: 0, | ||
| borderBottomLeftRadius: theme.shape.borderRadiusMedium, | ||
| overflow: 'auto', | ||
| ...(height && { height }), | ||
| })); | ||
|
|
||
| const StyledSidePanelHalfRight = styled(StyledSidePanelHalf)(({ theme }) => ({ | ||
| border: `1px solid ${theme.palette.divider}`, | ||
| borderTop: 0, | ||
| borderLeft: 0, | ||
| borderBottomRightRadius: theme.shape.borderRadiusMedium, | ||
| })); | ||
|
|
||
| type ColumnAlignment = 'start' | 'end' | 'center'; | ||
|
|
||
| export const StyledSidePanelListColumn = styled('div', { | ||
| shouldForwardProp: (prop) => prop !== 'maxWidth' && prop !== 'align', | ||
| })<{ maxWidth?: number; align?: ColumnAlignment }>( | ||
| ({ theme, maxWidth, align = 'start' }) => ({ | ||
| flex: 1, | ||
| padding: theme.spacing(2), | ||
| fontSize: theme.fontSizes.smallBody, | ||
| justifyContent: align, | ||
| ...(maxWidth && { maxWidth }), | ||
| textAlign: align, | ||
| }), | ||
| ); | ||
|
|
||
| export type SidePanelListColumn<T> = { | ||
| header: string; | ||
| maxWidth?: number; | ||
| align?: ColumnAlignment; | ||
| cell: (item: T) => ReactNode; | ||
| }; | ||
|
|
||
| interface ISidePanelListProps<T> { | ||
| items: T[]; | ||
| columns: SidePanelListColumn<T>[]; | ||
| sidePanelHeader: string; | ||
| renderContent: (item: T) => ReactNode; | ||
| height?: number; | ||
| listEnd?: ReactNode; | ||
| } | ||
|
|
||
| export const SidePanelList = <T extends { id: string | number }>({ | ||
| items, | ||
| columns, | ||
| sidePanelHeader, | ||
| renderContent, | ||
| height, | ||
| listEnd, | ||
| }: ISidePanelListProps<T>) => { | ||
| const [selectedItem, setSelectedItem] = useState<T>(items[0]); | ||
|
|
||
| if (items.length === 0) { | ||
| return null; | ||
| } | ||
|
|
||
| const activeItem = selectedItem || items[0]; | ||
|
|
||
| return ( | ||
| <StyledSidePanelListWrapper> | ||
| <SidePanelListHeader | ||
| columns={columns} | ||
| sidePanelHeader={sidePanelHeader} | ||
| /> | ||
| <StyledSidePanelListBody> | ||
| <StyledSidePanelHalfLeft height={height}> | ||
| {items.map((item) => ( | ||
| <SidePanelListItem | ||
| key={item.id} | ||
| selected={activeItem.id === item.id} | ||
| onClick={() => setSelectedItem(item)} | ||
| > | ||
| {columns.map( | ||
| ({ header, maxWidth, align, cell }) => ( | ||
| <StyledSidePanelListColumn | ||
| key={header} | ||
| maxWidth={maxWidth} | ||
| align={align} | ||
| > | ||
| {cell(item)} | ||
| </StyledSidePanelListColumn> | ||
| ), | ||
| )} | ||
| </SidePanelListItem> | ||
| ))} | ||
| {listEnd} | ||
| </StyledSidePanelHalfLeft> | ||
| <StyledSidePanelHalfRight> | ||
| {renderContent(activeItem)} | ||
| </StyledSidePanelHalfRight> | ||
| </StyledSidePanelListBody> | ||
| </StyledSidePanelListWrapper> | ||
| ); | ||
| }; |
48 changes: 48 additions & 0 deletions
48
frontend/src/component/common/SidePanelList/SidePanelListHeader.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| import { styled } from '@mui/material'; | ||
| import { | ||
| SidePanelListColumn, | ||
| StyledSidePanelListColumn, | ||
| } from './SidePanelList'; | ||
|
|
||
| const StyledHeader = styled('div')(({ theme }) => ({ | ||
| display: 'flex', | ||
| flexDirection: 'row', | ||
| alignItems: 'center', | ||
| borderTopLeftRadius: theme.shape.borderRadiusMedium, | ||
| borderTopRightRadius: theme.shape.borderRadiusMedium, | ||
| backgroundColor: theme.palette.table.headerBackground, | ||
| })); | ||
|
|
||
| const StyledHeaderHalf = styled('div')({ | ||
| display: 'flex', | ||
| flex: 1, | ||
| }); | ||
|
|
||
| interface ISidePanelListHeaderProps<T> { | ||
| columns: SidePanelListColumn<T>[]; | ||
| sidePanelHeader: string; | ||
| } | ||
|
|
||
| export const SidePanelListHeader = <T,>({ | ||
| columns, | ||
| sidePanelHeader, | ||
| }: ISidePanelListHeaderProps<T>) => ( | ||
| <StyledHeader> | ||
| <StyledHeaderHalf> | ||
| {columns.map(({ header, maxWidth, align }) => ( | ||
| <StyledSidePanelListColumn | ||
| key={header} | ||
| maxWidth={maxWidth} | ||
| align={align} | ||
| > | ||
| {header} | ||
| </StyledSidePanelListColumn> | ||
| ))} | ||
| </StyledHeaderHalf> | ||
| <StyledHeaderHalf> | ||
| <StyledSidePanelListColumn> | ||
| {sidePanelHeader} | ||
| </StyledSidePanelListColumn> | ||
| </StyledHeaderHalf> | ||
| </StyledHeader> | ||
| ); |
58 changes: 58 additions & 0 deletions
58
frontend/src/component/common/SidePanelList/SidePanelListItem.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,58 @@ | ||
| import { Button, styled } from '@mui/material'; | ||
| import { ReactNode } from 'react'; | ||
|
|
||
| const StyledItemRow = styled('div')(({ theme }) => ({ | ||
| borderBottom: `1px solid ${theme.palette.divider}`, | ||
| })); | ||
|
|
||
| const StyledItem = styled(Button, { | ||
| shouldForwardProp: (prop) => prop !== 'selected', | ||
| })<{ selected: boolean }>(({ theme, selected }) => ({ | ||
| '&.MuiButton-root': { | ||
| width: '100%', | ||
| backgroundColor: selected | ||
| ? theme.palette.secondary.light | ||
| : 'transparent', | ||
| borderRight: `${theme.spacing(0.5)} solid ${ | ||
| selected ? theme.palette.background.alternative : 'transparent' | ||
| }`, | ||
| padding: 0, | ||
| borderRadius: 0, | ||
| justifyContent: 'start', | ||
| transition: 'background-color 0.2s ease', | ||
| color: theme.palette.text.primary, | ||
| textAlign: 'left', | ||
| fontWeight: selected ? theme.fontWeight.bold : theme.fontWeight.medium, | ||
| fontSize: theme.fontSizes.smallBody, | ||
| overflow: 'auto', | ||
| }, | ||
| '&:hover': { | ||
| backgroundColor: selected | ||
| ? theme.palette.secondary.light | ||
| : theme.palette.neutral.light, | ||
| }, | ||
| '&.Mui-disabled': { | ||
| pointerEvents: 'auto', | ||
| }, | ||
| '&:focus-visible': { | ||
| outline: `2px solid ${theme.palette.primary.main}`, | ||
| }, | ||
| })); | ||
|
|
||
| interface ISidePanelListItemProps<T> { | ||
| selected: boolean; | ||
| onClick: () => void; | ||
| children: ReactNode; | ||
| } | ||
|
|
||
| export const SidePanelListItem = <T,>({ | ||
| selected, | ||
| onClick, | ||
| children, | ||
| }: ISidePanelListItemProps<T>) => ( | ||
| <StyledItemRow> | ||
| <StyledItem selected={selected} onClick={onClick}> | ||
| {children} | ||
| </StyledItem> | ||
| </StyledItemRow> | ||
| ); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This felt a tad noisy, but I guess this is where it belongs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, can't think of a better way of doing this right now, as I want this specific style for this component when used on the new side panel component.