chore: action_set_events db table migration #6298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
gastonfournier
approved these changes
Feb 21, 2024
| action_set JSONB NOT NULL | ||
| ); | ||
|
|
||
| CREATE INDEX IF NOT EXISTS idx_action_set_events_action_set_id ON action_set_events(action_set_id); |
There was a problem hiding this comment.
This first index is redundant as Postgres can use the compound index (third one): idx_action_set_events_action_set_id_state.
There was a problem hiding this comment.
Sure, addressed in 5e63801
nunogois
added a commit
that referenced
this pull request
Feb 21, 2024
Follow up to: #6298 We no longer need this table, since it was superseded by `action_events` and is no longer used. I believe it's safe to drop this table right away since the feature is not being used yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://linear.app/unleash/issue/2-1962/implement-new-action-events-logic
Adds a new
action_set_eventstable for the new action events logic.Even though observable events are technically immutable, we're storing the observable event along with the action set event. This allows us to avoid 1 join while allowing us to persist action set event information after deleting observable events, if we wish to do so at a later stage.