feat: show the metrics summary chart #6297
Conversation
Signed-off-by: andreas-unleash <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Code Health Quality Gates: OK
- Declining Code Health: 1 findings(s) 🚩
- Improving Code Health: 0 findings(s) ✅
- Affected Hotspots: 0 files(s) 🔥
Recommended Review Level: Lightweight sanity check
View detailed results in CodeScene
🚩 Declining Code Health (highest to lowest):
- Large Method ExecutiveDashboard.tsx: ExecutiveDashboard:VFC
andreas-unleash
changed the title
Signed-off-by: andreas-unleash <[email protected]>
There was a problem hiding this comment.
✅ Code Health Quality Gates: OK
- Declining Code Health: 1 findings(s) 🚩
- Improving Code Health: 0 findings(s) ✅
- Affected Hotspots: 0 files(s) 🔥
Recommended Review Level: Lightweight sanity check
View detailed results in CodeScene
🚩 Declining Code Health (highest to lowest):
- Large Method ExecutiveDashboard.tsx: ExecutiveDashboard:VFC
Signed-off-by: andreas-unleash <[email protected]>
Signed-off-by: andreas-unleash <[email protected]>
There was a problem hiding this comment.
✅ Code Health Quality Gates: OK
- Declining Code Health: 1 findings(s) 🚩
- Improving Code Health: 0 findings(s) ✅
- Affected Hotspots: 0 files(s) 🔥
Recommended Review Level: Lightweight sanity check
View detailed results in CodeScene
🚩 Declining Code Health (highest to lowest):
- Large Method ExecutiveDashboard.tsx: ExecutiveDashboard:VFC
There was a problem hiding this comment.
✅ Code Health Quality Gates: OK
- Declining Code Health: 1 findings(s) 🚩
- Improving Code Health: 0 findings(s) ✅
- Affected Hotspots: 0 files(s) 🔥
Recommended Review Level: Lightweight sanity check
View detailed results in CodeScene
🚩 Declining Code Health (highest to lowest):
- Large Method ExecutiveDashboard.tsx: ExecutiveDashboard:VFC
# Conflicts: # frontend/src/component/executiveDashboard/ExecutiveDashboard.tsx
There was a problem hiding this comment.
✅ Code Health Quality Gates: OK
- Declining Code Health: 1 findings(s) 🚩
- Improving Code Health: 0 findings(s) ✅
- Affected Hotspots: 0 files(s) 🔥
Recommended Review Level: Lightweight sanity check
View detailed results in CodeScene
🚩 Declining Code Health (highest to lowest):
- Large Method ExecutiveDashboard.tsx: ExecutiveDashboard:VFC
Signed-off-by: andreas-unleash <[email protected]>
…into feat/impressions_summary_chart
There was a problem hiding this comment.
✅ Code Health Quality Gates: OK
- Declining Code Health: 1 findings(s) 🚩
- Improving Code Health: 0 findings(s) ✅
- Affected Hotspots: 0 files(s) 🔥
Recommended Review Level: Lightweight sanity check
View detailed results in CodeScene
🚩 Declining Code Health (highest to lowest):
- Large Method ExecutiveDashboard.tsx: ExecutiveDashboard:VFC
| const { filteredProjectFlagTrends, filteredMetricsSummaryTrends } = | ||
| useMemo<FilteredProjectData>(() => { | ||
| if (projects[0] === allOption.id) { | ||
| return { | ||
| filteredProjectFlagTrends: | ||
| executiveDashboardData.projectFlagTrends, | ||
| filteredMetricsSummaryTrends: | ||
| executiveDashboardData.metricsSummaryTrends, | ||
| }; | ||
| } | ||
|
|
||
| const filteredProjectFlagTrends = | ||
| executiveDashboardData.projectFlagTrends.filter((trend) => | ||
| projects.includes(trend.project), | ||
| ) as ExecutiveSummarySchemaProjectFlagTrendsItem[]; |
There was a problem hiding this comment.
❌ New issue: Large Method
ExecutiveDashboard:VFC has 129 lines, threshold = 120
Why does this problem occur?
Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function. Read more.
To ignore this warning click here.
Creates the impressions summary chart
Closes # 1-2060