fix: maintenance mode should assume disable if db call fails. #6120
+13
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
Usually maintenance mode is disabled. If the call throws, which we see a lot of when a unleash instance is in terminating state, we should return a defualt value. By having it throw inside of the memoizee function, the response is not cached, and it will trigger new calls until it return a cachable result.
ivarconr
force-pushed
the
fix/maintenance-mode-handle-db-errors-with-default
branch
from
dcb50e0 to
f1bbef0
Compare
ivarconr
commented
Feb 3, 2024
| try { | ||
| return ( | ||
| this.config.flagResolver.isEnabled('maintenanceMode') || | ||
| (await this.resolveMaintenance()) |
There was a problem hiding this comment.
by allowing the momizee function to throw, we unsure it will not be cached.
gastonfournier
approved these changes
Feb 3, 2024
| @@ -193,7 +193,7 @@ export default class VersionService { | |||
| )) ?? { id: undefined }; | |||
| this.instanceId = id; | |||
| } catch (err) { | |||
| this.logger.warn('Could not find instanceInfo'); | |||
| this.logger.warn('Could not find instanceInfo', err); | |||
ivarconr
deleted the
fix/maintenance-mode-handle-db-errors-with-default
branch
gastonfournier
pushed a commit
that referenced
this pull request
Feb 5, 2024
Usually maintenance mode is disabled. If the call throws, which we see a lot of when a unleash instance is in terminating state, we should return a default value. By having it throw inside of the memoizee function, the response is not cached, and it will trigger new calls until it return a cachable result.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usually maintenance mode is disabled. If the call throws, which we see a lot of when a unleash instance is in terminating state, we should return a default value.
By having it throw inside of the memoizee function, the response is not cached, and it will trigger new calls until it return a cachable result.