Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add another system user for admin tokens #5915

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

gastonfournier
Copy link
Contributor

@gastonfournier gastonfournier commented Jan 16, 2024

About the changes

This admin token user will help us differentiate actions performed by the system from actions performed with an admin token.

Events created with an admin token should have the id of this user as createdByUserId property and the username of the token used as the createdBy property. i.e.

{
  "id": 11,
  "type": "pat-created",
  "createdBy": "admin-token",
  "createdAt": "2024-01-16T13:16:27.887Z",
  "createdByUserId": -42,
  "data": {
    "description": "admin-pat",
    "expiresAt": "2024-02-15T13:16:25.586Z",
    "secret": "***",
    "userId": 1
  },
  "preData": null,
  "tags": [],
  "featureName": null,
  "project": null,
  "environment": null
}

Copy link

vercel bot commented Jan 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Visit Preview Jan 16, 2024 2:52pm
unleash-monorepo-frontend ⬜️ Ignored (Inspect) Visit Preview Jan 16, 2024 2:52pm

@gastonfournier gastonfournier merged commit 04e5583 into main Jan 16, 2024
9 checks passed
@gastonfournier gastonfournier deleted the add-admin-tokens-user branch January 16, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants