Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add reason column to change request schedule table #5802

Merged
merged 2 commits into from
Jan 10, 2024

Conversation

thomasheartman
Copy link
Contributor

@thomasheartman thomasheartman commented Jan 9, 2024

This PR adds a new reason column to the change request schedules table and populates it with the data that is in the failure_reason column.

This is the expand phase of the expand/contract pattern. The code in enterprise will be updated to try and use the new column name, but fall back to the old one if no value is present.

The old column can be removed later.

Copy link

vercel bot commented Jan 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 9, 2024 10:33am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Visit Preview Jan 9, 2024 10:33am

@thomasheartman thomasheartman force-pushed the chore/rename-schedule-failure_reason-column branch from 7dba96a to 0d28f22 Compare January 9, 2024 09:57
@thomasheartman thomasheartman changed the title chore: rename failure_reason column to reason chore: add reason column to change request schedule table Jan 9, 2024
Copy link
Member

@ivarconr ivarconr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@thomasheartman thomasheartman merged commit e8ffea3 into main Jan 10, 2024
13 checks passed
@thomasheartman thomasheartman deleted the chore/rename-schedule-failure_reason-column branch January 10, 2024 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants