feat: adds created_by_user_id to all events #5619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
chriswk
force-pushed
the
feat/createdByUserIdOnEvents
branch
from
7241ef9 to
4c36da7
Compare
chriswk
force-pushed
the
feat/createdByUserIdOnEvents
branch
from
4e17b4d to
4e8290c
Compare
daveleek
approved these changes
Dec 14, 2023
| @@ -45,6 +45,7 @@ test('Should call datadog webhook', async () => { | |||
| createdAt: new Date(), | |||
| type: FEATURE_CREATED, | |||
| createdBy: '[email protected]', | |||
| createdByUserId: -1337, | |||
There was a problem hiding this comment.
nitpicking but we could use the constant here as well no?
| @@ -555,13 +562,15 @@ class FeatureToggleService { | |||
| strategyConfig, | |||
| context, | |||
| createdBy, | |||
| user?.id || SYSTEM_USER_ID, | |||
There was a problem hiding this comment.
is this being nullable related to how change requests work?
| @@ -1746,6 +1795,7 @@ class FeatureToggleService { | |||
| featureName, | |||
| }, | |||
| createdBy, | |||
| user?.id || SYSTEM_USER_ID, | |||
There was a problem hiding this comment.
Same question here, and goes for the other instances as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adds
createdByUserIdto all events exposed by unleash. In addition this PR updates all tests and usages of the methods in this codebase to include the required number.Dependencies
Points of discussion
This will break enterprise hard when merged, since all events constructed from enterprise codebase will not have the required
createdByUserIdfield. So, we'll need a planned merge, tomorrow (Wednesday) I'll prepare a PR on enterprise using this as a linked dependency to make sure I update all calls in enterprise as well.That should allow us to merge this, and then merge the PR on enterprise to reduce the broken build time to a minimum.