-
-
Notifications
You must be signed in to change notification settings - Fork 727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add created_by to role_permission table #5592
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -0,0 +1,7 @@ | |||
exports.up = function(db, cb) { | |||
db.runSql(`ALTER TABLE role_permission ADD COLUMN created_by INTEGER`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no callback
db.runSql(`ALTER TABLE role_permission ADD COLUMN created_by INTEGER`); | ||
}; | ||
|
||
exports.down = function(db) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no callback as parameters
ae95694
to
eed4949
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
As it says on the tin. In an attempt to make all operations in Unleash traceable to an originator. This PR adds created_by to role_permission, which will show which user assigned a permission to a role.