Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add created_by to role_permission table #5592

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

chriswk
Copy link
Member

@chriswk chriswk commented Dec 11, 2023

As it says on the tin. In an attempt to make all operations in Unleash traceable to an originator. This PR adds created_by to role_permission, which will show which user assigned a permission to a role.

@chriswk chriswk requested a review from daveleek December 11, 2023 13:29
@chriswk chriswk self-assigned this Dec 11, 2023
Copy link

vercel bot commented Dec 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2023 2:14pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Visit Preview Dec 11, 2023 2:14pm

Copy link
Contributor

@daveleek daveleek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -0,0 +1,7 @@
exports.up = function(db, cb) {
db.runSql(`ALTER TABLE role_permission ADD COLUMN created_by INTEGER`);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no callback

db.runSql(`ALTER TABLE role_permission ADD COLUMN created_by INTEGER`);
};

exports.down = function(db) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no callback as parameters

@chriswk chriswk force-pushed the task/addCreatedByToRolePermission branch from ae95694 to eed4949 Compare December 11, 2023 14:03
Copy link
Contributor

@daveleek daveleek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chriswk chriswk merged commit 0f250ba into main Dec 11, 2023
13 checks passed
@chriswk chriswk deleted the task/addCreatedByToRolePermission branch December 11, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants