Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new email template for scheduled-execution-failed email #5519

Merged
merged 7 commits into from
Dec 1, 2023

Conversation

andreas-unleash
Copy link
Contributor

@andreas-unleash andreas-unleash commented Dec 1, 2023

What it says on the box.

Relates to # 1-1687

Screenshot 2023-12-01 at 15 33 08

Copy link

vercel bot commented Dec 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Visit Preview Dec 1, 2023 1:12pm
unleash-monorepo-frontend ⬜️ Ignored (Inspect) Visit Preview Dec 1, 2023 1:12pm

Copy link
Contributor

@thomasheartman thomasheartman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got a couple things to sort out before we send this out. I'm assuming you've talked to someone with experience regarding the templates? It seems like a lot of html, but if that's how we do it, then that's how we do it 💁🏼

andreas-unleash and others added 3 commits December 1, 2023 14:39
Signed-off-by: andreas-unleash <[email protected]>
…email' into feat/scheduled-execution-failed-email
@andreas-unleash
Copy link
Contributor Author

andreas-unleash commented Dec 1, 2023

Yup. This is how we do it. Updated the screenshot to reflect changes from pr comments

Signed-off-by: andreas-unleash <[email protected]>
andreas-unleash and others added 2 commits December 1, 2023 15:10
…on-failed.html.mustache

Co-authored-by: Thomas Heartman <[email protected]>
…on-failed.plain.mustache

Co-authored-by: Thomas Heartman <[email protected]>
@andreas-unleash andreas-unleash merged commit be17b7f into main Dec 1, 2023
8 checks passed
@andreas-unleash andreas-unleash deleted the feat/scheduled-execution-failed-email branch December 1, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants