feat: Handle scheduled request events in addons #5403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: andreas-unleash <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
Signed-off-by: andreas-unleash <[email protected]>
thomasheartman
approved these changes
Nov 23, 2023
| @@ -140,6 +142,18 @@ const EVENT_MAP: Record<string, IEventData> = { | |||
| action: '*{{user}}* sent to review change request {{changeRequest}}', | |||
| path: '/projects/{{event.project}}/change-requests/{{event.data.changeRequestId}}', | |||
| }, | |||
| [CHANGE_REQUEST_SCHEDULED]: { | |||
| action: '*{{user}}* scheduled change request {{changeRequest}} in project *{{event.project}}*', | |||
There was a problem hiding this comment.
Can we add when it was scheduled for? Something like this?
Suggested change
| action: '*{{user}}* scheduled change request {{changeRequest}} in project *{{event.project}}*', | |
| action: '*{{user}}* scheduled change request {{changeRequest}} to be applied at {{time}} in project *{{event.project}}*', |
| path: '/projects/{{event.project}}/change-requests/{{event.data.changeRequestId}}', | ||
| }, | ||
| [CHANGE_REQUEST_SCHEDULED_APPLICATION_SUCCESS]: { | ||
| action: '*{{user}}* successfully applied scheduled change request {{changeRequest}} in project *{{event.project}}*', |
There was a problem hiding this comment.
Who is the user in this case? The same as the one that's usually used for CR applications?
And if we're changing the wording of the failed event, we could also change this one a bit:
Suggested change
| action: '*{{user}}* successfully applied scheduled change request {{changeRequest}} in project *{{event.project}}*', | |
| action: 'Successfully applied the scheduled change request {{changeRequest}} by *{{user}}* in project *{{project}}*.', |
There was a problem hiding this comment.
yes, the 'applier'.
| path: '/projects/{{event.project}}/change-requests/{{event.data.changeRequestId}}', | ||
| }, | ||
| [CHANGE_REQUEST_SENT_TO_REVIEW]: { | ||
| action: '*{{user}}* failed to apply scheduled change request {{changeRequest}} in project *{{event.project}}*', |
There was a problem hiding this comment.
Because this is an urgent event, maybe we should put thefailed bit first? Not very important, just a suggestion.
Suggested change
| action: '*{{user}}* failed to apply scheduled change request {{changeRequest}} in project *{{event.project}}*', | |
| action: '*Failed* to apply the scheduled change request {{changeRequest}} by *{{user}}* in project *{{project}}*.', |
Signed-off-by: andreas-unleash <[email protected]>
Signed-off-by: andreas-unleash <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3 events handled:
Closes # 1-1555
Note: SCHEDULED_CHANGE_REQUEST_EXECUTED will be removed in follow up PR not to break current enterprise build