feat: feature search basic functionality #5150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
kwasniew
commented
Oct 25, 2023
| { | ||
| name: 'query', | ||
| schema: { | ||
| default: '', |
There was a problem hiding this comment.
we need to investigate why the default is not set
kwasniew
commented
Oct 25, 2023
| { | ||
| name: 'projectId', | ||
| schema: { | ||
| default: '', |
There was a problem hiding this comment.
store should do * or %
kwasniew
commented
Oct 25, 2023
| @@ -56,6 +55,8 @@ export default class FeatureSearchController extends Controller { | |||
| summary: 'Search and filter features', | |||
| description: 'Search and filter by selected fields.', | |||
| operationId: 'searchFeatures', | |||
| // TODO: fix the type | |||
| parameters: featureSearchQueryParameters as any, | |||
There was a problem hiding this comment.
@thomasheartman can you help here? Do we have a standard method for externalizing query params to a type without type assertions?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
Basic search
Important files
Discussion points