fix: log diff #5072
Merged
fix: log diff #5072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
kwasniew
reviewed
Oct 17, 2023
| } | ||
| } | ||
|
|
||
| function arraysEqual(a: any[], b: any[]): boolean { |
There was a problem hiding this comment.
can we move this function out?
There was a problem hiding this comment.
I'd expect array equals signature to by typed: function arraysEqual<T>(a: T[], b: T[]): boolean
There was a problem hiding this comment.
also it's not really array equality since we sort the elements.
| valueB: any; | ||
| } | ||
|
|
||
| export function deepDiff(arr1: any[], arr2: any[]): Difference[] | null { |
There was a problem hiding this comment.
is there relationship between the arr1 and arr2 types?
deepDiff<T>(arr1: T[], arr2: T[]): Difference[] | null
There was a problem hiding this comment.
In this case they are different types.
FredrikOseberg
force-pushed
the
fix/log-diff
branch
from
3751fd1 to
781aaf3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a deep diff function to investigate diff in logs