feat: prevent adding dependency to archived or removed parent #4987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
kwasniew
commented
Oct 10, 2023
| @@ -0,0 +1,3 @@ | |||
| export interface IFeaturesReadModel { | |||
There was a problem hiding this comment.
introduced new read model in feature-toggle submodule so that we don't have to depend on feature-toggle-service with all write model operations.
kwasniew
commented
Oct 10, 2023
| .andWhere('archived_at', null) | ||
| .select('name'); | ||
|
|
||
| return rows.length > 0; |
There was a problem hiding this comment.
I find it more readable than inline select exists
FredrikOseberg
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
Prevents adding a dependency to a parent that was removed or archived or doesn't exist.
Important files
Discussion points
I'm not sure if we should fail those cases or just ignore. In the context of a change request we may end up in a situation where parent was deleted as the CR review was pending. So maybe it's better to show warning in CR and proceed without taking any action in the dependency service itself.