chore: handle transactions already started at the controller layer

[gastonfournier]

About the changes

This PR adds a method to safeguard us from opening a new transaction while inside another transaction, resulting in two isolated transactions that will not be atomic (if one fails, the other might still complete successfully).

https://github.com/knex/knex/blob/bbbe4d4637b3838e4a297a457460cd2c76a700d5/lib/knex-builder/make-knex.js#L143C5-L144C88

We're currently opening transactions at the controller layer

unleash/src/lib/features/export-import-toggles/export-import-controller.ts

Lines 206 to 208 in 2746bd1

	await this.exportImportServiceV2.transactional((service) =>
	service.import(dto, user),
	);

but in some other places, we do it at the store level:

unleash/src/lib/db/access-store.ts

Line 577 in 2746bd1

await this.db.transaction(async (tx) => {

Alternative

We can remove store-level transactions and move them to the controller following this approach:

unleash/src/lib/services/index.ts

Lines 282 to 284 in cb03497

	const exportImportServiceV2 = db
	? withTransactional(deferredExportImportTogglesService(config), db)
	: withFakeTransactional(createFakeExportImportTogglesService(config));

unleash/src/lib/features/export-import-toggles/export-import-controller.ts

Lines 206 to 208 in cb03497

	await this.exportImportServiceV2.transactional((service) =>
	service.import(dto, user),
	);

This option is more expensive because we have to:

1. Write the factory methods that propagate the transaction to the stores (therefore creating the store factory methods as well)
2. Identify the methods for creating the transactions at the store level and backtrack the calls until the controller layer

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
unleash-docs	❌ Failed (Inspect)			Oct 6, 2023 11:25am

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
unleash-monorepo-frontend	⬜️ Ignored (Inspect)	Visit Preview		Oct 6, 2023 11:25am

[gastonfournier]

This is nice to have... probably I can remove it from this PR

[kwasniew]

Very elegant solution. I'd like us to handle transactions around the service boundaries but it's great for the transitional period.

[gastonfournier]

Very elegant solution. I'd like us to handle transactions around the service boundaries but it's great for the transitional period.

Yes, I've added a comment in the method we're using