Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow to delete dependencies when no orphans #4952

Merged
merged 3 commits into from
Oct 6, 2023

Conversation

kwasniew
Copy link
Contributor

@kwasniew kwasniew commented Oct 6, 2023

About the changes

When bulk archiving/deleting parent and child and no other features depend on the parent then we should allow to archive/delete. However when we detect that archiving/deleting a parent would leave some orphan children then we don't want to allow it.

Important files

Discussion points

@vercel
Copy link

vercel bot commented Oct 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-docs ❌ Failed (Inspect) Oct 6, 2023 10:13am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
unleash-monorepo-frontend ⬜️ Ignored (Inspect) Visit Preview Oct 6, 2023 10:13am

Copy link
Contributor

@FredrikOseberg FredrikOseberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kwasniew kwasniew merged commit 8b0cf8b into main Oct 6, 2023
@kwasniew kwasniew deleted the dependent-features-orphan-detection branch October 6, 2023 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants