Clickable search filter options #4618
Merged
+68
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-suggestion-exit
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
kwasniew
commented
Sep 6, 2023
| @@ -148,7 +149,8 @@ export const Search = ({ | |||
| <Tooltip title="Clear search query" arrow> | |||
| <IconButton | |||
| size="small" | |||
| onClick={() => { | |||
| onClick={e => { | |||
| e.stopPropagation(); // prevent outside click from the lazily added element | |||
There was a problem hiding this comment.
search container ref couldn't see the icon button that is added in a conditional render. As a result the IconButton is not considered to be part of the searchContainerRef. It means that it was considered as a click outside of the searchContainerRef which closes the search. We don't want that so we stop event propagation.
kwasniew
commented
Sep 6, 2023
| /> | ||
| </div> | ||
| <SearchSuggestions | ||
| onSuggestion={suggestion => { |
There was a problem hiding this comment.
when people click on a suggestion we change the input and auto focus the input
kwasniew
commented
Sep 6, 2023
| }) => { | ||
| const searchContext = getSearchContext(); | ||
|
|
||
| const randomRow = useMemo( |
There was a problem hiding this comment.
this was generating combined filter and search hints that returned 0 results
kwasniew
requested review from
nunogois,
Tymek,
thomasheartman and
FredrikOseberg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
Screen.Recording.2023-09-06.at.12.14.38.mov
Main changes:
Important files
Discussion points