Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update menu for billing page #4525

Merged
merged 4 commits into from
Aug 18, 2023
Merged

Conversation

Tymek
Copy link
Member

@Tymek Tymek commented Aug 17, 2023

About the changes

  • Show admin menu on billing page in cloud offering. Category menu was not showing up because we have 2 different pages for billing (hosted or not)
  • Fix menu tab padding

https://linear.app/unleash/issue/1-1266/update-menu-for-billing-page

@vercel
Copy link

vercel bot commented Aug 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-docs ❌ Failed (Inspect) Aug 18, 2023 7:20am
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 18, 2023 7:20am

@@ -90,7 +90,7 @@ export const adminRoutes: INavigationMenuItem[] = [
{
path: '/admin/admin-invoices',
title: 'Billing & invoices',
menu: { adminSettings: true, mode: ['pro'], billing: true },
menu: { adminSettings: true, billing: true },
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic to show menu item is already handled by useInstanceStatus(), no need to specify "mode"

@Tymek Tymek merged commit 208ca05 into main Aug 18, 2023
@Tymek Tymek deleted the 1-1266-update-menu-for-billing-page branch August 18, 2023 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants