-
-
Notifications
You must be signed in to change notification settings - Fork 740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add usage info to project role deletion dialog #4464
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, but I think we can still do better, so I left a few comments.
Let me know if you need help tackling them 👍
frontend/src/component/admin/roles/RolesTable/RoleDeleteDialog/RoleDeleteDialog.tsx
Outdated
Show resolved
Hide resolved
...es/RolesTable/RoleDeleteDialog/RoleDeleteDialogProjectRoles/RoleDeleteDialogProjectRoles.tsx
Outdated
Show resolved
Hide resolved
...es/RolesTable/RoleDeleteDialog/RoleDeleteDialogProjectRoles/RoleDeleteDialogProjectRoles.tsx
Outdated
Show resolved
Hide resolved
...es/RolesTable/RoleDeleteDialog/RoleDeleteDialogProjectRoles/RoleDeleteDialogProjectRoles.tsx
Outdated
Show resolved
Hide resolved
...es/RolesTable/RoleDeleteDialog/RoleDeleteDialogProjectRoles/RoleDeleteDialogProjectRoles.tsx
Outdated
Show resolved
Hide resolved
...olesTable/RoleDeleteDialog/RoleDeleteDialogProjectRoles/RoleDeleteDialogProjectRoleTable.tsx
Outdated
Show resolved
Hide resolved
...olesTable/RoleDeleteDialog/RoleDeleteDialogProjectRoles/RoleDeleteDialogProjectRoleTable.tsx
Outdated
Show resolved
Hide resolved
…/RoleDeleteDialog.tsx Co-authored-by: Nuno Góis <[email protected]>
…/RoleDeleteDialogProjectRoles/RoleDeleteDialogProjectRoles.tsx Co-authored-by: Nuno Góis <[email protected]>
…/RoleDeleteDialogProjectRoles/RoleDeleteDialogProjectRoles.tsx Co-authored-by: Nuno Góis <[email protected]>
…/RoleDeleteDialogRootRoles/RoleDeleteDialogRootRoles.tsx Co-authored-by: Nuno Góis <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. Looks good to go.
About the changes
Adds projects user and group -usage information to the dialog shown when user wants to delete a project role