Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade docusaurus to 2.0.0.beta.14 from beta.9 #1249

Merged
merged 5 commits into from
Jan 11, 2022

Conversation

chriswk
Copy link
Contributor

@chriswk chriswk commented Jan 10, 2022

No description provided.

@vercel
Copy link

vercel bot commented Jan 10, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/unleash-team/unleash-docs/95GfoqjMuD22yawwg1aUExhcuTir
✅ Preview: https://unleash-docs-git-docusaurusversionbump-unleash-team.vercel.app

@github-actions
Copy link
Contributor

github-actions bot commented Jan 10, 2022

Coverage report

Total coverage

Status Category Percentage Covered / Total
🟢 Statements 92.04% 4612/5011
🟢 Branches 81.02% 717/885
🟢 Functions 87.84% 1084/1234
🟢 Lines 93.77% 5242/5590

Status of coverage: 🟢 - ok, 🟡 - slightly more than threshold, 🔴 - under the threshold

Report generated by 🧪jest coverage report action from 4917287

@ivarconr
Copy link
Member

Why is the build failing?

@thomasheartman
Copy link
Contributor

thomasheartman commented Jan 11, 2022

I think @chriswk said it was because the /integrations/integrations page now lives at /integrations instead.

The reason for this seems to be this PR in the docusaurus repo. From what I gather, there is a change that'll make pages called index, readme and the name of the subdirectory (e.g. /integrations/integrations) automatically get rendered at the subdir path (i.e. /integrations).

The reason for the above change is that categories can now have actual docs instead of being just containers. This means that instead of having an 'introduction' or 'overview' doc as the first subdoc of each category, the overview will now show when you click the category itself.

The link rewriting is actually in line with how we've done most of our docs (with index docs listed at the directory url). I also like the idea of not needing the 'overview' docs, but would be happy to discuss that.

Anyway, with that in mind, I'll see if I can't fix the build issues. Docusaurus recommends you link to the doc file instead of to a URL to get around issues like this, so I'll make some updates 🙋🏼

(Oh, and I found the above PR by coincidence earlier today when I was looking for some other stuff in their repo 💁🏼 )

Copy link
Contributor

@thomasheartman thomasheartman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🙋🏼

@thomasheartman thomasheartman merged commit 6944688 into master Jan 11, 2022
@thomasheartman thomasheartman deleted the docusaurusVersionBump branch January 11, 2022 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants