move trigger until after the insert. not before

Unleash · Oct 6, 2023 · bd3ff7b · bd3ff7b
1 parent 6f072a7
commit bd3ff7b
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 5 deletions.
diff --git a/src/lib/db/event-store.ts b/src/lib/db/event-store.ts
@@ -146,9 +146,7 @@ class EventStore implements IEventStore {
 
     async batchStore(events: IBaseEvent[]): Promise<void> {
         try {
-            await this.db(TABLE)
-                .insert(events.map(this.eventToDbRow))
-                .returning(EVENT_COLUMNS);
+            await this.db(TABLE).insert(events.map(this.eventToDbRow));
         } catch (error: unknown) {
             this.logger.warn(`Failed to store events: ${error}`);
         }

diff --git a/src/lib/features/instance-stats/getProductionChanges.e2e.test.ts b/src/lib/features/instance-stats/getProductionChanges.e2e.test.ts
@@ -1,4 +1,3 @@
-import { createGetActiveUsers, type GetActiveUsers } from './getActiveUsers';
 import dbInit, { type ITestDb } from '../../../test/e2e/helpers/database-init';
 import getLogger from '../../../test/fixtures/no-logger';
 import {

diff --git a/src/migrations/20231004120900-create-changes-stats-table-and-trigger.js b/src/migrations/20231004120900-create-changes-stats-table-and-trigger.js
@@ -18,7 +18,7 @@ exports.up = function(db, cb) {
     $unleash_update_changes_counter$ LANGUAGE plpgsql;
 
     CREATE TRIGGER unleash_update_stat_environment_changes
-    BEFORE INSERT ON events
+    AFTER INSERT ON events
     FOR EACH ROW EXECUTE FUNCTION unleash_update_stat_environment_changes_counter();
   `, cb);
 };