Skip to content

Commit

Permalink
chore: wait to input the name of the segment when checking for error …
Browse files Browse the repository at this point in the history
…messages (#7377)

This change adds a wait statement before entering the name of the
segment when checking for error messages that this segment name
already exists.

This is the same workaround that we did in
#7289, which seems to have
worked.

Like in that PR, using waits is still an antipattern, but it appears
to be working.

Maybe it’s time to look more deeply at why it happens? Why isn’t the
field ready to receive input even though it’s on the page? Is it mui’s
fault or ours?
  • Loading branch information
thomasheartman authored Jun 12, 2024
1 parent 557c499 commit b5de65b
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions frontend/cypress/integration/segments/segments.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ describe('segments', () => {

it('gives an error if a segment exists with the same name', () => {
cy.get("[data-testid='NAVIGATE_TO_CREATE_SEGMENT']").click();
cy.wait(500);
cy.get("[data-testid='SEGMENT_NAME_ID']").type(segmentName);
cy.get("[data-testid='SEGMENT_NEXT_BTN_ID']").should('be.disabled');
cy.get("[data-testid='INPUT_ERROR_TEXT']").contains(
Expand Down

0 comments on commit b5de65b

Please sign in to comment.