Skip to content

Commit

Permalink
chore: rename roles toggles to flag
Browse files Browse the repository at this point in the history
  • Loading branch information
sjaanus committed May 23, 2024
1 parent 7937301 commit 54b2f40
Show file tree
Hide file tree
Showing 2 changed files with 37 additions and 2 deletions.
32 changes: 32 additions & 0 deletions src/migrations/20240523113322-roles-toggle-to-flag-rename.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
exports.up = function (db, cb) {
db.runSql(`
UPDATE roles
SET description = 'Users with the project owner role have full control over the project, and can add and manage other users within the project context, manage feature flags within the project, and control advanced project features like archiving and deleting the project.'
WHERE name = 'Owner'
AND type = 'project';
UPDATE roles
SET description = 'Users with the project member role are allowed to view, create, and update feature flags within a project, but have limited permissions in regards to managing the project''s user access and can not archive or delete the project.'
WHERE name = 'Member'
AND type = 'project';
`, cb);
};

exports.down = function (db, cb) {
db.runSql(
`
UPDATE roles
SET description = 'Users with the project owner role have full control over the project, and can add and manage other users within the project context, manage feature toggles within the project, and control advanced project features like archiving and deleting the project.'
WHERE name = 'Owner'
AND type = 'project';
UPDATE roles
SET description = 'Users with the project member role are allowed to view, create, and update feature toggles within a project, but have limited permissions in regards to managing the project''s user access and can not archive or delete the project.'
WHERE name = 'Member'
AND type = 'project';
`,
cb,
);
};
7 changes: 5 additions & 2 deletions src/test/e2e/favor-permission-name-over-id.e2e.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,9 @@ test('Favor permission name over id migration correctly assigns permissions by n
{ role_id: 101, permission: 'TEST_PERMISSION_4' },
]);

// Run the toggle to flag update migration
await dbm.up('20240523113322-roles-toggle-to-flag-rename.js');

// Check the results that ensure the default roles exist and have the correct permissions
const { rows: resultsRoles } = await client.query(`
SELECT name, description, type FROM "favor_permission_name_over_id_test"."roles" WHERE id != 101 ORDER BY created_at;
Expand Down Expand Up @@ -142,13 +145,13 @@ test('Favor permission name over id migration correctly assigns permissions by n
{
name: 'Owner',
description:
'Users with the project owner role have full control over the project, and can add and manage other users within the project context, manage feature toggles within the project, and control advanced project features like archiving and deleting the project.',
'Users with the project owner role have full control over the project, and can add and manage other users within the project context, manage feature flags within the project, and control advanced project features like archiving and deleting the project.',
type: 'project',
},
{
name: 'Member',
description:
"Users with the project member role are allowed to view, create, and update feature toggles within a project, but have limited permissions in regards to managing the project's user access and can not archive or delete the project.",
"Users with the project member role are allowed to view, create, and update feature flags within a project, but have limited permissions in regards to managing the project's user access and can not archive or delete the project.",
type: 'project',
},
]);
Expand Down

0 comments on commit 54b2f40

Please sign in to comment.