chore: upgrade to yarn v4 (#7230)

![Outdated as of 2020](https://github.com/Unleash/unleash/assets/177402/689a1bcc-441d-4b87-88a6-125e68a17f26) This has been on our TODO list for a long time. We're moving to latest released at the time of commit (v4.2.2)
Unleash · Jun 7, 2024 · 15726cc · 15726cc
1 parent 215608c
commit 15726cc
Show file tree

Hide file tree

Showing 35 changed files with 47,902 additions and 31,798 deletions.
diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml
@@ -40,7 +40,9 @@ jobs:
         with:
           node-version: 20.x
           cache: 'yarn'
-      - run: yarn install --frozen-lockfile --ignore-scripts
+      - run: yarn install --immutable
+        env:
+          YARN_ENABLE_SCRIPTS: false
       - run: yarn lint
       - run: yarn build:backend
       - run: yarn run test:report # This adds test results as github check to the workflow

diff --git a/.github/workflows/build_frontend_prs.yml b/.github/workflows/build_frontend_prs.yml
@@ -19,8 +19,8 @@ jobs:
         uses: actions/setup-node@v4
         with:
           node-version: 20.x
+      - run: yarn --immutable
       - run: yarn run lint:material:icons
-      - run: yarn --frozen-lockfile
       - run: yarn run lint:check
       - run: yarn run test
       - run: yarn run ts:check # TODO: optimize
diff --git a/.github/workflows/dependency-review.yml b/.github/workflows/dependency-review.yml
@@ -17,5 +17,5 @@ jobs:
         uses: actions/dependency-review-action@v4
         with:
           fail-on-severity: moderate
-          allow-licenses: Apache-2.0, MIT, BSD-2-Clause, BSD-3-Clause, ISC, CC0-1.0, Unlicense
+          allow-licenses: Apache-2.0, MIT, BSD-2-Clause, BSD-3-Clause, ISC, CC0-1.0, Unlicense, BlueOak-1.0.0
           comment-summary-in-pr: always
diff --git a/.github/workflows/e2e.frontend.yaml b/.github/workflows/e2e.frontend.yaml
@@ -20,9 +20,10 @@ jobs:
       - name: Checkout
         uses: actions/checkout@v4
       - name: Run Cypress
-        uses: cypress-io/github-action@v5
+        uses: cypress-io/github-action@v6
         with:
           working-directory: frontend
           env: AUTH_USER=admin,AUTH_PASSWORD=unleash4all
           config: baseUrl=${{ github.event.deployment_status.target_url }}
           spec: cypress/integration/${{ matrix.test }}
+          install-command: yarn --immutable
diff --git a/.github/workflows/gradual-strict-null-checks.yml b/.github/workflows/gradual-strict-null-checks.yml
@@ -50,9 +50,9 @@ jobs:
           YARN_1="yarn --mutex network --cwd ./current"
           YARN_2="yarn --mutex network --cwd ./main"
 
-          $YARN_1 install --ignore-scripts &> /dev/null && $YARN_1 build:backend --strictNullChecks true 2> .stderr-current > .out-current &
+          $YARN_1 install  &> /dev/null && $YARN_1 build:backend --strictNullChecks true 2> .stderr-current > .out-current &
           pid1=$!
-          $YARN_2 install --ignore-scripts &> /dev/null && $YARN_2 build:backend --strictNullChecks true 2> .stderr-main > .out-main &
+          $YARN_2 install  &> /dev/null && $YARN_2 build:backend --strictNullChecks true 2> .stderr-main > .out-main &
           pid2=$!
 
           # wait for the processes that are expected to fail

diff --git a/.github/workflows/notify_enterprise.yaml b/.github/workflows/notify_enterprise.yaml
@@ -12,12 +12,13 @@ jobs:
   build:
     runs-on: ubuntu-latest
 
-    strategy:
-      matrix:
-        node-version: [20.x]
-
     steps:
       - uses: actions/checkout@v4
+      - name: Use Node.js 20
+        uses: actions/setup-node@v4
+        with:
+          node-version: 20.x
+          cache: 'yarn'
       - name: Trigger sync
         uses: actions/github-script@v7
         env:
@@ -42,7 +43,7 @@ jobs:
       - name: Build static assets
         run: |
           cd frontend
-          yarn install --frozen-lockfile
+          yarn install --immutable
           yarn build
       - uses: aws-actions/configure-aws-credentials@v2
         with:

diff --git a/.github/workflows/publish-new-version.yaml b/.github/workflows/publish-new-version.yaml
@@ -6,7 +6,7 @@ concurrency:
 
 permissions:
   contents: write
-  id-token: write  
+  id-token: write
 
 on:
   workflow_dispatch:
@@ -30,7 +30,7 @@ jobs:
 
     strategy:
       matrix:
-        node-version: [20.x]
+        node-version: [ 20.x ]
 
     steps:
       - uses: actions/checkout@v4
@@ -66,10 +66,12 @@ jobs:
           else
             echo "No changes to CHANGELOG.md"
           fi
-      - run: yarn install --frozen-lockfile --ignore-scripts
+      - run: yarn install --immutable
+        env:
+          YARN_ENABLE_SCRIPTS: false
       - name: npm version
         run: |
-          npm version ${{ github.event.inputs.version }} --ignore-scripts
+          npm version ${{ github.event.inputs.version }}
           git push origin ${{ github.ref_name }}
           git push --tags
         env:
@@ -104,8 +106,10 @@ jobs:
         run: git checkout origin/${{ github.ref_name }} -- CHANGELOG.md
       - name: lint
         run: |
-          yarn install --frozen-lockfile --ignore-scripts
+          yarn install --immutable
           yarn lint:fix
+        env:
+          YARN_ENABLE_SCRIPTS: false
       - name: push changes
         run: |
           git add package.json CHANGELOG.md
@@ -118,7 +122,7 @@ jobs:
     secrets: inherit
     with:
       version: ${{ github.event.inputs.version }}
-  
+
   publish-npm:
     needs: build
     uses: ./.github/workflows/release.yaml

diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml
@@ -27,7 +27,7 @@ jobs:
           cache: 'yarn'
       - name: Build
         run: |
-          yarn install --frozen-lockfile
+          yarn install --immutable
       - name: Publish to npm
         run: |
           LATEST=$(npm show unleash-server version)

diff --git a/.github/workflows/validate-migrations.yaml b/.github/workflows/validate-migrations.yaml
@@ -18,8 +18,8 @@ jobs:
       - name: Use Node.js 20.x
         uses: actions/setup-node@v4
         with:
-            node-version: 20.x
-            cache: 'yarn'
+          node-version: 20.x
+          cache: 'yarn'
       - name: Start database
         working-directory: test-migrations
         run: docker compose up db -d --wait -t 90
@@ -29,16 +29,18 @@ jobs:
       # add some data with terraform
       - name: Apply migrations
         env:
-            DATABASE_URL: postgres://postgres:unleash@localhost:5432/unleash
-            DATABASE_SSL: false
+          DATABASE_URL: postgres://postgres:unleash@localhost:5432/unleash
+          DATABASE_SSL: false
+          YARN_ENABLE_SCRIPTS: false
         run: |
-          yarn install --frozen-lockfile --ignore-scripts
+          yarn install --immutable
           yarn db-migrate up
       # run ui tests against previous version of Unleash
       - name: Run Cypress
-        uses: cypress-io/github-action@v5
+        uses: cypress-io/github-action@v6
         with:
           working-directory: frontend
           env: AUTH_USER=admin,AUTH_PASSWORD=unleash4all
           config: baseUrl=http://localhost:4242
           spec: cypress/oss/**/*.spec.ts
+          install-command: yarn --immutable
diff --git a/.yarn/install-state.gz b/.yarn/install-state.gz
diff --git a/.yarn/releases/yarn-4.2.2.cjs b/.yarn/releases/yarn-4.2.2.cjs
diff --git a/.yarnrc.yml b/.yarnrc.yml
@@ -0,0 +1,3 @@
+nodeLinker: node-modules
+
+yarnPath: .yarn/releases/yarn-4.2.2.cjs
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
@@ -7,6 +7,10 @@ Before you begin:
 - Have you read the [code of conduct](CODE_OF_CONDUCT.md)?
 - Check out the [existing issues](https://github.com/unleash/Unleash/issues)
 - Browse the [developer-guide](./website/docs/contributing/developer-guide.md) for tips on environment setup, running the tests, and running Unleash from source.
+- You need 
+  - Node 20
+  - corepack enabled `corepack enable`
+  - yarn installed globally `npm install -g yarn`
 
 ### Don't see your issue? Open one
 

diff --git a/Dockerfile b/Dockerfile
@@ -6,18 +6,18 @@ WORKDIR /unleash
 
 COPY . /unleash
 
-RUN yarn config set network-timeout 300000
+RUN corepack enable
 
-RUN yarn install --frozen-lockfile --ignore-scripts && yarn prepare:backend && yarn local:package
+RUN yarn install --immutable  && yarn prepare:backend && yarn local:package
 
 # frontend/build should already exist (it needs to be built in the local filesystem but in case of a fresh build we'll build it here)
-RUN yarn build:frontend:if-needed
+RUN yarn build:frontend
 
 RUN mkdir -p /unleash/build/frontend && mv /unleash/frontend/build /unleash/build/frontend/build
 
 WORKDIR /unleash/docker
 
-RUN yarn install --frozen-lockfile --production=true
+RUN yarn install
 
 FROM node:$NODE_VERSION
 

diff --git a/biome.json b/biome.json
@@ -53,7 +53,9 @@
       "src/test/examples/*.json",
       ".docusaurus",
       "coverage",
-      "CHANGELOG.md"
+      "CHANGELOG.md",
+      "./package.json",
+      "./frontend/package.json"
     ]
   },
   "organizeImports": {
@@ -74,7 +76,9 @@
       "coverage",
       "website/build",
       "website/global.js",
-      ".docusaurus"
+      ".docusaurus",
+      "./package.json",
+      "./frontend/package.json"
     ],
     "indentWidth": 4
   },

diff --git a/docker/.yarn/install-state.gz b/docker/.yarn/install-state.gz
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,3 @@
		nodeLinker: node-modules

		yarnPath: .yarn/releases/yarn-4.2.2.cjs