-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow minor changes in enum-map
#68
base: main
Are you sure you want to change the base?
Conversation
So the locking was a response to a bug in enum-map - long fixed I think - combined with the limitation that its macro (at that time) could not be re-exported (and we haven't tested since to see if it can be now) - so the crate version of enum-map is part of the public API of unleash-rust-client.
I think rather than changing this, bumping the version to 2.6.3, and investigating the ability to re-export the derive macro (which is now in its own crate!) would be great |
It is not possible to get
|
Yah, I had opened a bug at the time, but the maintainer has moved bug trackers twice since then I think, so probably we need to file it all over again. |
Hmm, can't find that bug - since you've done the recent revalidation, could you perhaps file it upstream? |
I could, but I probably need to understand better why this is a bug. The other point to address is the msrv. How should that be addressed? Do you wish to bump it, or should depend on a compatible version of |
It is a feature request for enum-map, but as that bug says, strum made it work quite well - Peternator7/strum#170 for instance
note the addition of a concrete module path; which can be used when using the macro. So for instance
Or for us, we'd document
.. or something like that. |
For the MSRV, that looks like they have a hard dep. I think raising to 1.61 is fine, thats 10 releases ago now. |
About the changes
Replace the
~
with the default^
so to unlock minor updates inenum-map
.The minor being lock may be too strict (?) and might (and in fact does) prevent users from updating their dependencies.
Discussion points
It compiles, but I am unsure about the reason for locking the minor in the first place.
Introduced here b7bd91f#diff-2e9d962a08321605940b5a657135052fbcef87b5e360662bb527c96d9a615542R46