Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme update hosted docs #1137

Merged
merged 4 commits into from
Oct 10, 2024
Merged

Readme update hosted docs #1137

merged 4 commits into from
Oct 10, 2024

Conversation

fmauch
Copy link
Collaborator

@fmauch fmauch commented Oct 9, 2024

Update broken links from README and add a URL checker to CI.

This way we should find our earlier if a link breaks.
@fmauch fmauch added the documentation Improvements or additions to documentation label Oct 9, 2024
@fmauch fmauch requested a review from VinDp October 9, 2024 12:06
Copy link
Collaborator

@VinDp VinDp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed the broken links today, apparently I was not quick enough in making an issue! Besides that, looks good and seems to work!

@fmauch
Copy link
Collaborator Author

fmauch commented Oct 9, 2024

No, it doesn't work yet. Please do not merge yet

@fmauch fmauch changed the title Readme update hosted docs WIP: Readme update hosted docs Oct 9, 2024
@VinDp
Copy link
Collaborator

VinDp commented Oct 9, 2024

Yep, I noticed after approving

@fmauch
Copy link
Collaborator Author

fmauch commented Oct 9, 2024

@VinDp now it is working as expected.

@fmauch fmauch changed the title WIP: Readme update hosted docs Readme update hosted docs Oct 9, 2024
@fmauch fmauch requested a review from VinDp October 10, 2024 09:24
Copy link
Collaborator

@VinDp VinDp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@VinDp VinDp merged commit ff3ce21 into main Oct 10, 2024
7 of 12 checks passed
@VinDp VinDp deleted the readme_update_hosted_docs branch October 10, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants