Replace keepalive count #1002
Merged
Replace keepalive count #1002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmauch
force-pushed
the
remove_keepalive_count
branch
from
592cae2
to
7b91a84
Compare
fmauch
force-pushed
the
remove_keepalive_count
branch
from
7b91a84
to
3bfb962
Compare
4 tasks
VinDp
force-pushed
the
remove_keepalive_count
branch
from
3bfb962
to
2046c7e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
keepalive_counthas been deprecated in the ur_client_library for quite some time now. This PR removes it also from the driver and replaces it byrobot_receive_timeout.Note: This cannot be directly backported, since for iron and humble we need to do it backwards-compatible. I will provide a separate PR for this.