Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update nomenclature of the simulators to aovid user's confusion. #104

Closed
wants to merge 1 commit into from
Closed

Update nomenclature of the simulators to aovid user's confusion. #104

wants to merge 1 commit into from

Conversation

destogl
Copy link
Contributor

@destogl destogl commented Oct 8, 2023

This PR provides a small nomenclature update of gazebo / ignition name to be consistent to the naming used by community.

fmauch
fmauch approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@fmauch fmauch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @destogl I wanted to clean this up for a long time. Are there any plans to also update the ros2_control packages / SystemInterfaces accordingly?

fmauch
fmauch suggested changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@fmauch fmauch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the tests there seem to be some parts missing.

@fmauch
Copy link
Contributor

fmauch commented Dec 18, 2023

Closing this, since simulator support now moved to the simulator repos (See UniversalRobots/Universal_Robots_ROS2_Gazebo_Simulation#41 and UniversalRobots/Universal_Robots_ROS2_GZ_Simulation#7)

@fmauch fmauch closed this Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmauch fmauch fmauch requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@destogl @fmauch