-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dates, times, addresses, currency, numbers in v2 guidelines and English data #455
Comments
Agreed. I have made this a v2.1 milestone. |
From skimming #210, it seems that different syntactic constructions can become conventional ways to express dates. Perhaps the best solution would be not to force a uniform structure, but to subtype relations with Thus, for English, something like: Thursday, July 4, 1776 Thursday, the 4th of July, 1776 While the head is "July" in the first case and "4th" in the second case, in both cases the 4 pieces of the date (weekday, month, date, year) are connected via relations with |
Some observations:
Currency: A currency symbol should be related to a numeric amount via
nummod
(e.g. in "$ 40"), but in the English data it is sometimescompound
.Dates:
flat
includes examples of dates, but the English data hasnummod
(e.g., “March 28”)Times: There is no apparent guideline for "10:00 pm" or "10 o'clock". In the English data, "a.m." and "p.m." are attached as
nummod
.Addresses: It is not clear what the standard should be—
flat
?—for expressions like "100 Main St. NW Apt. 10".Spelled-out numbers:
flat
gives the example "four thousand", but the English data hascompound
(e.g., these examples with "million")The text was updated successfully, but these errors were encountered: