implemented deletion of notices at expiry date #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tools/docker-dev/sql/bootstrap.sql
Outdated
| @@ -156,7 +157,7 @@ CREATE TABLE `notices` ( | |||
|
|
|||
| INSERT INTO `notices` (`id`, `date`, `title`, `message`) VALUES | |||
There was a problem hiding this comment.
Shouldn't there be an 'expiry' here?
tools/docker-dev/unity-web-portal
Outdated
There was a problem hiding this comment.
Is this new directory meant to be here?
bryank-cs
reviewed
Sep 17, 2024
| @@ -17,6 +17,10 @@ | |||
|
|
|||
| $notices = $SQL->getNotices(); | |||
| foreach ($notices as $notice) { | |||
| if ($notice["expiry"] < date('Y-m-d')) { | |||
| $SQL->deleteNotice($notice["id"]); | |||
There was a problem hiding this comment.
Doing the deletion here causes a race condition if two page loads happen at the same time and so try to delete the same items. This will cause it to throw an exception.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#89