feat: add multitenancy module #8
Conversation
Make java warnings as errors as opt-in for new modules
I did not apply the warnings as errors configuration to the multi-tenancy module. I did not know how to make it pass for the TenantArgumentBinder class. I put the multitenancy code in a separate module not using assertj and with the package io.micronaut.multienancy since I plan to contribute it to Micronaut Multitenancy. I added the nullable tenant parameter to the repositories to be in a position to handle multi-tenant persistence in the future.
This reverts commit 228fdba.
There was a problem hiding this comment.
@sdelamo I took the liberty to push some changes to fix those compilation warnings.
Please see my comments about license headers and version numbers.
multitenancy/src/main/java/io/micronaut/multitenancy/Tenant.java
Outdated
Show resolved
Hide resolved
multitenancy/src/main/java/io/micronaut/multitenancy/Tenant.java
Outdated
Show resolved
Hide resolved
multitenancy/src/main/java/io/micronaut/multitenancy/http/MultitenancyFilter.java
Outdated
Show resolved
Hide resolved
multitenancy/src/main/java/io/micronaut/multitenancy/http/MultitenancyFilterConfiguration.java
Outdated
Show resolved
Hide resolved
multitenancy/src/main/java/io/micronaut/multitenancy/http/MultitenancyFilter.java
Outdated
Show resolved
Hide resolved
.../src/main/java/io/micronaut/multitenancy/http/MultitenancyFilterConfigurationProperties.java
Outdated
Show resolved
Hide resolved
multitenancy/src/main/java/io/micronaut/multitenancy/http/TenantArgumentBinder.java
Outdated
Show resolved
Hide resolved
multitenancy/src/main/java/io/micronaut/multitenancy/http/TenantArgumentBinder.java
Outdated
Show resolved
Hide resolved
multitenancy/src/main/java/io/micronaut/multitenancy/http/package-info.java
Outdated
Show resolved
Hide resolved
multitenancy/src/main/java/io/micronaut/multitenancy/http/package-info.java
Outdated
Show resolved
Hide resolved
I added the license and the version to match the license and the expected version of Micronaut Multitenancy. This code will be contributed to http://github.com/micronaut-projects/micronaut-multitenancy |
That's perfect. I understand we will be deleting these classes from projectcheckins and use them via Micronaut dependency once the new version is released. However, this PR creates local classes to this project, and "version 5.3.0" has no meaning in the context of projectcheckins. I also think that license should be consistent throughout the entire project. Code comments or Javadoc have no impact on backward compatibility, so we should be able to merge these classes minus the Micronaut baggage here, and eventually replace them with Micronaut's without the need for an additional refactor. |
Co-authored-by: Guillermo Calvo <[email protected]>
Co-authored-by: Guillermo Calvo <[email protected]>
I did not apply the warnings as errors configuration to the multi-tenancy module. I did not know how to make it pass for the TenantArgumentBinder class.
I put the multitenancy code in a separate module not using assertj and with the package io.micronaut.multienancy since I plan to contribute it to Micronaut Multitenancy.
I added the nullable tenant parameter to the repositories to be in a position to handle multi-tenant persistence in the future.