Merge pull request #158 from HootDunk/bug/table-view-cannot-select-row

don't use default value for array prop as svelte handles them in inco…
UnityFoundation-io · Mar 12, 2024 · dac7679 · dac7679
2 parents b14375a + 4cb96f0
commit dac7679
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 8 deletions.
diff --git a/frontend/src/lib/components/SelectedValues.svelte b/frontend/src/lib/components/SelectedValues.svelte
@@ -1,7 +1,7 @@
 <script lang="ts">
 	import type { SelectedValue } from '$lib/services/Libre311/Libre311';
 
-	export let selectedValues: SelectedValue[] = [];
+	export let selectedValues: SelectedValue[];
 </script>
 
 {#each selectedValues as selectedValue}

diff --git a/frontend/src/lib/components/ServiceRequestDetails.svelte b/frontend/src/lib/components/ServiceRequestDetails.svelte
@@ -58,10 +58,11 @@
 					<p class="text-sm">{serviceRequest.address}</p>
 				</div>
 
-				<div class="mb-1">
-					<SelectedValues selectedValues={serviceRequest.selected_values} />
-				</div>
-
+				{#if serviceRequest.selected_values}
+					<div class="mb-1">
+						<SelectedValues selectedValues={serviceRequest.selected_values} />
+					</div>
+				{/if}
 				{#if serviceRequest.description}
 					<div class="mb-1">
 						<strong class="text-base">{messages['serviceRequest']['description']}</strong>

diff --git a/frontend/src/lib/components/ServiceRequestUpdate.svelte b/frontend/src/lib/components/ServiceRequestUpdate.svelte
@@ -175,9 +175,11 @@
 					<p class="text-sm">{serviceRequest.address}</p>
 				</div>
 
-				<div class="mb-1">
-					<SelectedValues selectedValues={serviceRequest.selected_values} />
-				</div>
+				{#if serviceRequest.selected_values}
+					<div class="mb-1">
+						<SelectedValues selectedValues={serviceRequest.selected_values} />
+					</div>
+				{/if}
 
 				{#if serviceRequest.description}
 					<div class="mb-1">