Fix matching logic for logs from namespace when lines = 0 #5660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bawjensen
commented
Aug 19, 2023
bawjensen
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #5658 |
| License | MIT |
| Doc PR | N/A (?) |
|
|
bawjensen
commented
Aug 19, 2023
Comment on lines
+101
to
+105
| var isMatchingProcess = id === 'all' | ||
| || packet.process.name === id | ||
| || packet.process.pm_id === id | ||
| || packet.process.namespace === id; | ||
| if (!isMatchingProcess) |
There was a problem hiding this comment.
separating out isMatchingProcess felt more readable to me - happy to revert back to something like this instead:
if (id !== 'all'
&& packet.process.name != id
&& packet.process.pm_id != id
&& packet.process.namespace != id)There was a problem hiding this comment.
I used the most recently added test/e2e/logs/ case as a template, hoping to use the most modern test patterns
| $pm2 start echo.js --namespace e2e-test-log-namespace | ||
|
|
||
| LOG_FILE_BASELINE="${LOG_PATH_PREFIX}/baseline-out.log" | ||
| $pm2 logs e2e-test-log-namespace > $LOG_FILE_BASELINE & # backgrounded - will be stopped by `$pm2 delete all` |
There was a problem hiding this comment.
I haven't seen any e2e (or programmatic tests) for the pm2 logs command, in order to mimic those. So this is a bit of a shot in the dark, with this approach of backgrounding the process.
bawjensen
force-pushed
the
fix-namespace-lines-0
branch
from
078dfaf to
fd2dc00
Compare
Unitech
added a commit
that referenced
this pull request
Oct 6, 2023
|
fixed via [email protected] $ npm install [email protected]
$ pm2 update |
This was referenced Jun 15, 2024
This was referenced Jun 30, 2024
This was referenced Jul 5, 2024
This was referenced Jul 18, 2024
This was referenced Aug 22, 2024
This was referenced Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.