-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove jacodb-analysis module #280
Conversation
Also remove jacodb-examples, jacodb-panda-static and some tests in jacodb-ets, since they heavily depend on jacodb-analysis
Let's call it Volkswagen PR at the moment |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## neo #280 +/- ##
=============================================
+ Coverage 59.50% 70.75% +11.24%
+ Complexity 2615 2404 -211
=============================================
Files 320 241 -79
Lines 19376 13843 -5533
Branches 2880 2035 -845
=============================================
- Hits 11530 9794 -1736
+ Misses 6761 3187 -3574
+ Partials 1085 862 -223 ☔ View full report in Codecov by Sentry. |
We have some analysis missed from the USVM. Since it is jvm specific we can move it to |
@Saloed |
UnitTestBot/usvm#222 was merged, all analyses from |
This PR removes
jacodb-analysis
module, which was moved into USVM (see https://github.com/UnitTestBot/usvm/tree/main/usvm-dataflow).Note that this PR also removes some tests in
jacodb-ets
(related to analysis, they are already being moved to USVM), and modulesjacodb-panda-static
(obsolete) andjacodb-cli
(heavily depend onjacodb-analysis
). FWIW, it should not be a problem, as these modules are barely used by anyone, but the README and documentation now becomes somewhat outdated.