Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove jacodb-analysis module #280

Merged
merged 4 commits into from
Dec 9, 2024
Merged

Remove jacodb-analysis module #280

merged 4 commits into from
Dec 9, 2024

Conversation

Lipen
Copy link
Member

@Lipen Lipen commented Dec 5, 2024

This PR removes jacodb-analysis module, which was moved into USVM (see https://github.com/UnitTestBot/usvm/tree/main/usvm-dataflow).

Note that this PR also removes some tests in jacodb-ets (related to analysis, they are already being moved to USVM), and modules jacodb-panda-static (obsolete) and jacodb-cli (heavily depend on jacodb-analysis). FWIW, it should not be a problem, as these modules are barely used by anyone, but the README and documentation now becomes somewhat outdated.

Also remove jacodb-examples, jacodb-panda-static and some tests in jacodb-ets, since they heavily depend on jacodb-analysis
@Lipen Lipen requested a review from CaelmBleidd December 5, 2024 13:05
Copy link
Contributor

github-actions bot commented Dec 5, 2024

Lifecycle test results

78 tests  ±0   78 ✅ ±0   1m 46s ⏱️ +2s
 7 suites ±0    0 💤 ±0 
 7 files   ±0    0 ❌ ±0 

Results for commit faa1b6c. ± Comparison against base commit 81ccf5a.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Dec 5, 2024

Test results on JDK 19

 66 files   -    22   66 suites   - 22   4m 17s ⏱️ - 9m 4s
532 tests  - 1 997  524 ✅  - 1 964  8 💤  - 33  0 ❌ ±0 
560 runs   - 1 997  552 ✅  - 1 964  8 💤  - 33  0 ❌ ±0 

Results for commit faa1b6c. ± Comparison against base commit 81ccf5a.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Dec 5, 2024

Test results on JDK 11

 66 files   -    22   66 suites   - 22   4m 53s ⏱️ - 10m 27s
532 tests  - 1 997  526 ✅  - 1 964  6 💤  - 33  0 ❌ ±0 
560 runs   - 1 997  554 ✅  - 1 964  6 💤  - 33  0 ❌ ±0 

Results for commit faa1b6c. ± Comparison against base commit 81ccf5a.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Dec 5, 2024

Test results on JDK 8

 66 files   -    22   66 suites   - 22   4m 34s ⏱️ - 12m 10s
532 tests  - 1 997  521 ✅  - 1 964  11 💤  - 33  0 ❌ ±0 
560 runs   - 1 997  549 ✅  - 1 964  11 💤  - 33  0 ❌ ±0 

Results for commit faa1b6c. ± Comparison against base commit 81ccf5a.

♻️ This comment has been updated with latest results.

@lehvolk
Copy link
Collaborator

lehvolk commented Dec 5, 2024

Let's call it Volkswagen PR at the moment

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.75%. Comparing base (81ccf5a) to head (faa1b6c).
Report is 1 commits behind head on neo.

Additional details and impacted files
@@              Coverage Diff              @@
##                neo     #280       +/-   ##
=============================================
+ Coverage     59.50%   70.75%   +11.24%     
+ Complexity     2615     2404      -211     
=============================================
  Files           320      241       -79     
  Lines         19376    13843     -5533     
  Branches       2880     2035      -845     
=============================================
- Hits          11530     9794     -1736     
+ Misses         6761     3187     -3574     
+ Partials       1085      862      -223     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Saloed
Copy link
Collaborator

Saloed commented Dec 5, 2024

We have some analysis missed from the USVM. Since it is jvm specific we can move it to usvm-jvm-dataflow.

https://github.com/UnitTestBot/jacodb/blob/neo/jacodb-analysis/src/main/kotlin/org/jacodb/analysis/impl/custom/ReachingDefinitionsAnalysis.kt

@Lipen
Copy link
Member Author

Lipen commented Dec 6, 2024

@Saloed ReachingDefinitionsAnalysis is unused in jacodb, should we still keep it, even so there are no tests for it?
As for the NullAssumptionAnalysis, it has some tests in jacodb, but these tests depend on BaseTest, which is defined in jacodb-core's testFixture module, which is not published, so these tests in jacodb-analysis/test cannot be simply transferred to USVM, and without the tests there is not point in transferring only the analyses. Should we nevertheless move the whole test infrastructure for these analyses to USVM? Or maybe make the testFixture module in jacodb-core publishable?

@Lipen
Copy link
Member Author

Lipen commented Dec 9, 2024

UnitTestBot/usvm#222 was merged, all analyses from jacodb-analysis are now in usvm-dataflow

@Lipen Lipen merged commit 8b8750d into neo Dec 9, 2024
10 checks passed
@Lipen Lipen deleted the lipen/remove-analysis branch December 9, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants