Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix cjs release #438

Merged
merged 3 commits into from
Feb 26, 2022
Merged

fix cjs release #438

merged 3 commits into from
Feb 26, 2022

Conversation

zzmp
Copy link
Contributor

@zzmp zzmp commented Feb 25, 2022

Eliminating "type": "module" marks this as a "commonjs" package.

This should force dependencies to load as cjs, sidestepping #379: use-sync-external-store's non-fully-specified path (which breaks when loaded as esm).

@vercel
Copy link

vercel bot commented Feb 25, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/noahwz/web3-react/CfH9YDo1zqAYck9L7pjv5VEysneg
✅ Preview: Failed

[Deployment for 2409c5b failed]

@NoahZinsmeister NoahZinsmeister merged commit 7d7d225 into Uniswap:cjs Feb 26, 2022
NoahZinsmeister pushed a commit that referenced this pull request Feb 28, 2022
* fix cjs release

* only rename index.cjs

* simplify renaming with postbuild
NoahZinsmeister added a commit that referenced this pull request Feb 28, 2022
* cut cjs release

* Publish

 - @web3-react/[email protected]
 - @web3-react/[email protected]
 - @web3-react/[email protected]
 - @web3-react/[email protected]
 - @web3-react/[email protected]
 - @web3-react/[email protected]
 - @web3-react/[email protected]
 - @web3-react/[email protected]
 - @web3-react/[email protected]
 - @web3-react/[email protected]
 - @web3-react/[email protected]
 - @web3-react/[email protected]

* fix cjs release (#438)

* fix cjs release

* only rename index.cjs

* simplify renaming with postbuild

* restore module field

* Publish

 - @web3-react/[email protected]
 - @web3-react/[email protected]
 - @web3-react/[email protected]
 - @web3-react/[email protected]
 - @web3-react/[email protected]
 - @web3-react/[email protected]
 - @web3-react/[email protected]
 - @web3-react/[email protected]
 - @web3-react/[email protected]
 - @web3-react/[email protected]
 - @web3-react/[email protected]
 - @web3-react/[email protected]

* try using mjs

explicit folders for mjs and cjs

* bump example

* update yarn.lock

Co-authored-by: Zach Pomerantz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants