Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove PoolGetters #683

Merged
merged 1 commit into from
May 22, 2024
Merged

Remove PoolGetters #683

merged 1 commit into from
May 22, 2024

Conversation

havi-kim
Copy link
Contributor

Related Issue

Which issue does this pull request resolve?
#680

Description of changes

snreynolds
snreynolds approved these changes May 21, 2024
View reviewed changes
Copy link
Member

@snreynolds snreynolds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@hensha256 hensha256 enabled auto-merge (squash) May 21, 2024 19:50
@hensha256
Copy link
Contributor

hey @havi-kim ! please can you sign your commit? we cannot merge any un-signed commits

auto-merge was automatically disabled May 22, 2024 03:43

Head branch was pushed to by a user without write access

@havi-kim havi-kim force-pushed the remove_poolGetters_and_replace_with_extsload_equivalents branch from ffd7fd3 to ba86910 Compare May 22, 2024 03:43
@hensha256
Copy link
Contributor

hey @havi-kim ! its still not signed 😞 youll know its signed when it says verified next to the commit hash. See this PR as an example.

Screenshot 2024-05-22 at 09 50 43

@havi-kim
Copy link
Contributor Author

@hensha256
Thank you so much for your kind explanation.
I've signed it. Could you please check if it'sverified?

@hensha256
Copy link
Contributor

Yess I now see verified! Will run CI and then merge it 🚀

@hensha256 hensha256 enabled auto-merge (squash) May 22, 2024 13:02
@hensha256 hensha256 merged commit b538356 into Uniswap:main May 22, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hensha256 hensha256 hensha256 approved these changes

@snreynolds snreynolds snreynolds approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@havi-kim @hensha256 @snreynolds