[copy of #340] perf: optimize poolKey.toId() (skip abi.encode) #550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Merlin Egalite <[email protected]>
Co-authored-by: Merlin Egalite <[email protected]>
Co-authored-by: Merlin Egalite <[email protected]>
adhusson
changed the title
hensha256
reviewed
Apr 3, 2024
test/types/PoolKey.t.sol
Outdated
| contract TestPoolKey is Test { | ||
| using PoolIdLibrary for PoolKey; | ||
|
|
||
| function testPoolIdCreation(PoolKey memory poolKey) public { |
There was a problem hiding this comment.
I think this file isnt actually needed - it does the same as PoolId.t.sol
There was a problem hiding this comment.
Then I can merge into our temp branch :)
hensha256
approved these changes
Apr 3, 2024
snreynolds
approved these changes
Apr 3, 2024
|
Thanks!! Feel free to squash and merge and then reopen that new branch onto main :) |
I don't have write access so I can't merge I think? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
copy of #340 to get CI to run