add reverting tests, fix fuzz for hooks.t.sol #548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Forge code coverage:
|
hensha256
reviewed
Apr 3, 2024
hensha256
reviewed
Apr 3, 2024
hensha256
reviewed
Apr 3, 2024
hensha256
reviewed
Apr 3, 2024
hensha256
requested changes
Apr 3, 2024
hensha256
reviewed
May 17, 2024
test/libraries/Hooks.t.sol
Outdated
| // Set the upper `hooksPermissionCount` number of bits to get the full mask in uint16. | ||
| uint16 allHooksMask = (~uint16(0) << uint16(16 - hookPermissionCount)); | ||
| // We want any combination except all hooks. | ||
| vm.assume(mask < allHooksMask); |
There was a problem hiding this comment.
the name of the test is failsAllHooks as if it has all hooks - but this test explicitly doesnt have all hooks?
There was a problem hiding this comment.
OH i see its that validateHookPermissions has all hooks
hensha256
previously approved these changes
May 17, 2024
|
can you make all the import paths in Hooks.t.sol relative? |
|
i forget, did we want to change the hook flags to be uint160 instead of uint256? |
dianakocsis
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Which issue does this pull request resolve?
Description of changes